Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add transport stream to VIDEO file formats #6855

Closed
1 of 2 tasks
apiszcz opened this issue Mar 4, 2022 · 4 comments · Fixed by #6859
Closed
1 of 2 tasks

Please add transport stream to VIDEO file formats #6855

apiszcz opened this issue Mar 4, 2022 · 4 comments · Fixed by #6859
Labels
enhancement New feature or request

Comments

@apiszcz
Copy link

apiszcz commented Mar 4, 2022

Search before asking

  • I have searched the YOLOv5 issues and found no similar feature requests.

Description

Can transport stream be added , tested and it works fine.

utils/datasets.py (line 37)

FROM
VID_FORMATS = ['mov', 'avi', 'mp4', 'mpg', 'mpeg', 'm4v', 'wmv', 'mkv'] # acceptable video suffixes

TO
VID_FORMATS = ['mov', 'avi', 'mp4', 'mpg', 'mpeg', 'm4v', 'wmv', 'mkv', 'ts'] # acceptable video suffixes

Use case

Allow more input file formats.

Additional

Please consider adding a frame skip parameter.

Are you willing to submit a PR?

  • Yes I'd like to help by submitting a PR!
@apiszcz apiszcz added the enhancement New feature or request label Mar 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2022

👋 Hello @apiszcz, thank you for your interest in YOLOv5 🚀! Please visit our ⭐️ Tutorials to get started, where you can find quickstart guides for simple tasks like Custom Data Training all the way to advanced concepts like Hyperparameter Evolution.

If this is a 🐛 Bug Report, please provide screenshots and minimum viable code to reproduce your issue, otherwise we can not help you.

If this is a custom training ❓ Question, please provide as much information as possible, including dataset images, training logs, screenshots, and a public link to online W&B logging if available.

For business inquiries or professional support requests please visit https://ultralytics.com or email [email protected].

Requirements

Python>=3.7.0 with all requirements.txt installed including PyTorch>=1.7. To get started:

git clone https://github.com/ultralytics/yolov5  # clone
cd yolov5
pip install -r requirements.txt  # install

Environments

YOLOv5 may be run in any of the following up-to-date verified environments (with all dependencies including CUDA/CUDNN, Python and PyTorch preinstalled):

Status

CI CPU testing

If this badge is green, all YOLOv5 GitHub Actions Continuous Integration (CI) tests are currently passing. CI tests verify correct operation of YOLOv5 training (train.py), validation (val.py), inference (detect.py) and export (export.py) on MacOS, Windows, and Ubuntu every 24 hours and on every commit.

@glenn-jocher
Copy link
Member

glenn-jocher commented Mar 4, 2022

@apiszcz hi, thank you for your feature suggestion on how to improve YOLOv5 🚀! Yes if *.ts extensions are working then please add them to the list of approved suffixes in a PR here:

yolov5/utils/datasets.py

Lines 34 to 38 in 601dbb8

# Parameters
HELP_URL = 'https://github.com/ultralytics/yolov5/wiki/Train-Custom-Data'
IMG_FORMATS = ['bmp', 'dng', 'jpeg', 'jpg', 'mpo', 'png', 'tif', 'tiff', 'webp'] # include image suffixes
VID_FORMATS = ['asf', 'avi', 'gif', 'm4v', 'mkv', 'mov', 'mp4', 'mpeg', 'mpg', 'wmv'] # include video suffixes

Please see our ✅ Contributing Guide to get started.

@apiszcz apiszcz changed the title Please transport stream to VIDEO file formats Please add transport stream to VIDEO file formats Mar 4, 2022
@apiszcz
Copy link
Author

apiszcz commented Mar 4, 2022

apiszcz#1

@glenn-jocher
Copy link
Member

glenn-jocher commented Mar 4, 2022

@apiszcz good news 😃! Your original issue may now be fixed ✅ in PR #6859. To receive this update:

  • Gitgit pull from within your yolov5/ directory or git clone https://github.com/ultralytics/yolov5 again
  • PyTorch Hub – Force-reload model = torch.hub.load('ultralytics/yolov5', 'yolov5s', force_reload=True)
  • Notebooks – View updated notebooks Open In Colab Open In Kaggle
  • Dockersudo docker pull ultralytics/yolov5:latest to update your image Docker Pulls

Thank you for spotting this issue and informing us of the problem. Please let us know if this update resolves the issue for you, and feel free to inform us of any other issues you discover or feature requests that come to mind. Happy trainings with YOLOv5 🚀!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants