Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call to Detections.__init__() missing 1 required positional argument: 'files' #5944

Closed
2 tasks done
yonomitt opened this issue Dec 10, 2021 · 3 comments · Fixed by #5945
Closed
2 tasks done

Call to Detections.__init__() missing 1 required positional argument: 'files' #5944

yonomitt opened this issue Dec 10, 2021 · 3 comments · Fixed by #5945
Labels
bug Something isn't working

Comments

@yonomitt
Copy link
Contributor

Search before asking

  • I have searched the YOLOv5 issues and found no similar bug report.

YOLOv5 Component

Detection

Bug

Calling .tolist() on a Detections object crashes with the following message:

  File "/****/.cache/torch/hub/ultralytics_yolov5_master/models/common.py", line 615, in <listcomp>
    x = [Detections([self.imgs[i]], [self.pred[i]], names=self.names, shape=self.s) for i in range(self.n)]
TypeError: __init__() missing 1 required positional argument: 'files'

There was a recent change (PR #5907), which fixed another bug. Unfortunately, it seems to have introduced this one.

Environment

No response

Minimal Reproducible Example

No response

Additional

No response

Are you willing to submit a PR?

  • Yes I'd like to help by submitting a PR!
@yonomitt yonomitt added the bug Something isn't working label Dec 10, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2021

👋 Hello @yonomitt, thank you for your interest in YOLOv5 🚀! Please visit our ⭐️ Tutorials to get started, where you can find quickstart guides for simple tasks like Custom Data Training all the way to advanced concepts like Hyperparameter Evolution.

If this is a 🐛 Bug Report, please provide screenshots and minimum viable code to reproduce your issue, otherwise we can not help you.

If this is a custom training ❓ Question, please provide as much information as possible, including dataset images, training logs, screenshots, and a public link to online W&B logging if available.

For business inquiries or professional support requests please visit https://ultralytics.com or email Glenn Jocher at [email protected].

Requirements

Python>=3.6.0 with all requirements.txt installed including PyTorch>=1.7. To get started:

$ git clone https://github.com/ultralytics/yolov5
$ cd yolov5
$ pip install -r requirements.txt

Environments

YOLOv5 may be run in any of the following up-to-date verified environments (with all dependencies including CUDA/CUDNN, Python and PyTorch preinstalled):

Status

CI CPU testing

If this badge is green, all YOLOv5 GitHub Actions Continuous Integration (CI) tests are currently passing. CI tests verify correct operation of YOLOv5 training (train.py), validation (val.py), inference (detect.py) and export (export.py) on MacOS, Windows, and Ubuntu every 24 hours and on every commit.

@yonomitt
Copy link
Contributor Author

Don't worry, bot, I'm working on the PR.

@glenn-jocher glenn-jocher added the TODO High priority items label Dec 10, 2021
@glenn-jocher glenn-jocher removed the TODO High priority items label Dec 11, 2021
@glenn-jocher
Copy link
Member

glenn-jocher commented Dec 11, 2021

@yonomitt good news 😃! Your original issue may now be fixed ✅ in PR #5945. To receive this update:

  • Gitgit pull from within your yolov5/ directory or git clone https://github.com/ultralytics/yolov5 again
  • PyTorch Hub – Force-reload model = torch.hub.load('ultralytics/yolov5', 'yolov5s', force_reload=True)
  • Notebooks – View updated notebooks Open In Colab Open In Kaggle
  • Dockersudo docker pull ultralytics/yolov5:latest to update your image Docker Pulls

Thank you for spotting this issue and informing us of the problem. Please let us know if this update resolves the issue for you, and feel free to inform us of any other issues you discover or feature requests that come to mind. Happy trainings with YOLOv5 🚀!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants