Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update format.yml #2308

Merged
merged 1 commit into from
Dec 7, 2024
Merged

Update format.yml #2308

merged 1 commit into from
Dec 7, 2024

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Dec 7, 2024

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Updated GitHub Actions to better handle pull request workflows for yolov3.

πŸ“Š Key Changes

  • Replaced pull_request_target with pull_request in .github/workflows/format.yml.
  • Updated the workflow to trigger on PR events such as opened, closed, synchronize, and review_requested on the main and master branches.

🎯 Purpose & Impact

  • πŸ”§ Improved Security: Using pull_request instead of pull_request_target helps limit potential security risks from untrusted code in forks.
  • βœ… Enhanced PR Handling: Ensures the workflow runs on a wider range of PR events for better automation and review consistency.
  • πŸ”„ Streamlined Workflow Management: Makes PR handling more aligned with standard CI/CD practices, improving the development experience.

Signed-off-by: Glenn Jocher <[email protected]>
@UltralyticsAssistant UltralyticsAssistant added devops GitHub Devops or MLops enhancement New feature or request labels Dec 7, 2024
@UltralyticsAssistant
Copy link
Member

πŸ‘‹ Hello @glenn-jocher, thank you for submitting an ultralytics/yolov3 πŸš€ PR! To ensure a seamless integration of your work, please review the following checklist:

  • βœ… Define a Purpose: Clearly explain the purpose of your fix or feature in your PR description, and link to any relevant issues. Ensure your commit messages are clear, concise, and adhere to the project's conventions.
  • βœ… Synchronize with Source: Confirm your PR is synchronized with the ultralytics/yolov3 main branch. If it's behind, update it by clicking the 'Update branch' button or by running git pull and git merge main locally.
  • βœ… Ensure CI Checks Pass: Verify all Ultralytics Continuous Integration (CI) checks are passing. If any checks fail, please address the issues.
  • βœ… Update Documentation: Update the relevant documentation for any new or modified features.
  • βœ… Add Tests: If applicable, include or update tests to cover your changes, and confirm that all tests are passing.
  • βœ… Sign the CLA: Please ensure you have signed our Contributor License Agreement if this is your first Ultralytics PR by writing "I have read the CLA Document and I sign the CLA" in a new message.
  • βœ… Minimize Changes: Limit your changes to the minimum necessary for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." β€” Bruce Lee

Thank you for the detailed PR description and summary! 🌟 The proposed changes to the GitHub Actions workflow sound great for improving security and maintaining compatibility with modern practices πŸ”’. Please ensure all workflow updates have been validated to avoid any unintended issues upon merging.

For more guidance, please refer to our Contributing Guide. This is an automated response πŸ› οΈ, but an Ultralytics engineer will review your PR shortly and provide additional feedback if needed. πŸš€

@UltralyticsAssistant
Copy link
Member

πŸ‘‹ Hello @glenn-jocher, thank you for submitting an ultralytics/yolov3 πŸš€ PR! To ensure a seamless integration of your work, please review the following checklist:

  • βœ… Define a Purpose: Clearly explain the purpose of your fix or feature in your PR description, and link to any relevant issues. Ensure your commit messages are clear, concise, and adhere to the project's conventions.
  • βœ… Synchronize with Source: Confirm your PR is synchronized with the ultralytics/yolov3 main branch. If it's behind, update it by clicking the 'Update branch' button or by running git pull and git merge main locally.
  • βœ… Ensure CI Checks Pass: Verify all Ultralytics Continuous Integration (CI) checks are passing. If any checks fail, please address the issues.
  • βœ… Update Documentation: Update the relevant documentation for any new or modified features.
  • βœ… Add Tests: If applicable, include or update tests to cover your changes, and confirm that all tests are passing.
  • βœ… Sign the CLA: Please ensure you have signed our Contributor License Agreement if this is your first Ultralytics PR by writing "I have read the CLA Document and I sign the CLA" in a new message.
  • βœ… Minimize Changes: Limit your changes to the minimum necessary for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." β€” Bruce Lee

For more guidance, please refer to our Contributing Guide. Don’t hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! πŸš€

πŸ” A friendly note: this is an automated response to help you get started. An Ultralytics engineer will review your PR shortly and provide further feedback if needed. πŸ‘

@glenn-jocher glenn-jocher merged commit 549240b into master Dec 7, 2024
9 checks passed
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-1 branch December 7, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops GitHub Devops or MLops enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants