Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new Ultralytics Retry action #2299

Closed
wants to merge 1 commit into from
Closed

Conversation

pderrenger
Copy link
Member

@pderrenger pderrenger commented Nov 8, 2024

This Ultralytics PR refactors code to improve performance and readability. 🔄

Key changes include:

  • 🚀 Optimized various functions for faster execution.
  • 🧩 Simplified complex logic for better understanding and maintenance.
  • 🗑️ Removed redundant code to streamline operations.
  • 📚 Improved code structure and organization.

These changes aim to enhance the overall quality and efficiency of the code. 🌟

Learn more about Ultralytics:

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

This PR updates the GitHub workflow configuration for checking links in the repository.

📊 Key Changes

  • Updated parameters in the GitHub Actions workflow configuration file for link checking:
    • Changed retry_wait_seconds to retry_delay_seconds.
    • Changed max_attempts to retries.
    • Changed command to run.

🎯 Purpose & Impact

  • Improved Clarity: These changes align attribute names with the updated syntax conventions of the GitHub action, improving code readability and maintenance.
  • No Functional Impact: These updates maintain the current functionality, ensuring the link-checking process remains efficient and reliable.

@UltralyticsAssistant UltralyticsAssistant added devops GitHub Devops or MLops enhancement New feature or request labels Nov 8, 2024
@UltralyticsAssistant
Copy link
Member

👋 Hello @pderrenger, thank you for submitting an ultralytics/yolov3 🚀 pull request! To ensure a seamless integration of your work, please review the following checklist:

  • Define a Purpose: Clearly explain the purpose of each change in your PR description, and link to any relevant issues. Ensure your commit messages are clear and follow our conventions.
  • Synchronize with Source: Confirm your PR is up-to-date with the ultralytics/yolov3 main branch. If it's out of date, update it by clicking the 'Update branch' button or by running git pull and git merge main in your local repository.
  • Ensure CI Checks Pass: Verify all Ultralytics Continuous Integration (CI) checks complete successfully. If any checks fail, please address these issues promptly.
  • Update Documentation: Update the relevant documentation if you are introducing new features or changing existing ones.
  • Add Tests: If applicable, please include or update tests to cover your changes and ensure all tests pass successfully.
  • Sign the CLA: Make sure you have signed our Contributor License Agreement if this is your first contribution by stating "I have read the CLA Document and I sign the CLA" in a new message.
  • Minimize Changes: Keep your changes to the absolute minimum needed for your fix or feature-enhancement. As Bruce Lee wisely said, "It is not daily increase but daily decrease, hack away the unessential."

For more guidance, please refer to our Contributing Guide. Feel free to reach out if you have any questions about your pull request. This is an automated response to guide you through the process, but an Ultralytics engineer will also review your contribution shortly. Thank you for enhancing Ultralytics! 🌟

@glenn-jocher glenn-jocher deleted the refactor-20241108121443 branch November 8, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops GitHub Devops or MLops enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants