From b8c8567c126dbe04fd09118b2c5191e9ce70534b Mon Sep 17 00:00:00 2001 From: Blake Byrnes Date: Fri, 30 Aug 2024 17:24:19 -0400 Subject: [PATCH] chore: up minimum profile versions --- browser-profiler/main/scripts/runBrowserstack.ts | 5 +++-- browser-profiler/main/scripts/runBrowserstackDoms.ts | 5 +++++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/browser-profiler/main/scripts/runBrowserstack.ts b/browser-profiler/main/scripts/runBrowserstack.ts index 8f43a0c82..1ea36d044 100644 --- a/browser-profiler/main/scripts/runBrowserstack.ts +++ b/browser-profiler/main/scripts/runBrowserstack.ts @@ -33,10 +33,11 @@ export default async function runBrowserstack(): Promise { } // too old for the double agent suite - if (browser.name === 'Firefox' && Number(browser.version.major) < 63) continue; + if (browser.name === 'Firefox' && Number(browser.version.major) < 100) continue; // TODO: The dom environment plugin hangs <= 94. Need to investigate for scraper report eventually if (browser.name === 'Chrome' && Number(browser.version.major) < 95) continue; - if (browser.name === 'Safari' && Number(browser.version.major) < 11) continue; + if (browser.name === 'Edge' && Number(browser.version.major) < 95) continue; + if (browser.name === 'Safari' && Number(browser.version.major) < 13) continue; // no support for Promises, lambdas... detections need refactor for support if (browser.name === 'IE') continue; diff --git a/browser-profiler/main/scripts/runBrowserstackDoms.ts b/browser-profiler/main/scripts/runBrowserstackDoms.ts index 44c77a07b..55aac0d1b 100644 --- a/browser-profiler/main/scripts/runBrowserstackDoms.ts +++ b/browser-profiler/main/scripts/runBrowserstackDoms.ts @@ -39,8 +39,13 @@ export default async function runBrowserstack(): Promise { continue; } + if (browser.name === 'Firefox' && Number(browser.version.major) < 100) continue; // TODO: The dom environment plugin hangs <= 94. Need to investigate for scraper report eventually if (browser.name === 'Chrome' && Number(browser.version.major) < 95) continue; + if (browser.name === 'Edge' && Number(browser.version.major) < 95) continue; + if (browser.name === 'Safari' && Number(browser.version.major) < 13) continue; + // no support for Promises, lambdas... detections need refactor for support + if (browser.name === 'IE') continue; // 1. Does this need to run? Clean up as needed. const domDir = Path.join(baseDomsDir, `${userAgentId}--${features}`);