This repository has been archived by the owner on May 13, 2024. It is now read-only.
feat: spread out blog plugin options to theme options (close #34) #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billyyyyy3320
changed the title
billyyyyy3320
force-pushed
the
feat/options
branch
from
f6a6b38
to
ee5101b
Compare
billyyyyy3320
changed the title
billyyyyy3320
added a commit
that referenced
this pull request
Jan 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Relevant issue #34
Adding simple tests to protect default configuration, but I currently don't have the right to enable ci.
IMO, it makes theme config more intuitive. We probably have to deprecate
modifyBlogPluginOptions. It'll be a breaking change.What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)