You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The graveyard creation can be slow as it loops through every shape in the Reactor
Perhaps adding an optional argument to the reactor.make_graveyard method that allows a subset of shapes to be searched would be helpful.
Then for reactors we often know the biggest component (normally TF coils) so this could be used to make the graveyard and we could skip other components
This should cut down on the number of components the bounding box is constructed for and therefore reduce the compute time required.
Might be best to either do this after #743 is merged on a branch from then #743 branch as there are some changes to the Graveyard filename in that PR
The text was updated successfully, but these errors were encountered:
The graveyard creation can be slow as it loops through every shape in the Reactor
Perhaps adding an optional argument to the reactor.make_graveyard method that allows a subset of shapes to be searched would be helpful.
Then for reactors we often know the biggest component (normally TF coils) so this could be used to make the graveyard and we could skip other components
This should cut down on the number of components the bounding box is constructed for and therefore reduce the compute time required.
Might be best to either do this after #743 is merged on a branch from then #743 branch as there are some changes to the Graveyard filename in that PR
The text was updated successfully, but these errors were encountered: