Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up graveyard creation #753

Open
shimwell opened this issue Mar 1, 2021 · 2 comments
Open

Speed up graveyard creation #753

shimwell opened this issue Mar 1, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@shimwell
Copy link
Collaborator

shimwell commented Mar 1, 2021

The graveyard creation can be slow as it loops through every shape in the Reactor

Perhaps adding an optional argument to the reactor.make_graveyard method that allows a subset of shapes to be searched would be helpful.

Then for reactors we often know the biggest component (normally TF coils) so this could be used to make the graveyard and we could skip other components

This should cut down on the number of components the bounding box is constructed for and therefore reduce the compute time required.

Might be best to either do this after #743 is merged on a branch from then #743 branch as there are some changes to the Graveyard filename in that PR

@shimwell
Copy link
Collaborator Author

shimwell commented Mar 1, 2021

This was found in #733 which is failing CI because the graveyard creation is slow

@RemDelaporteMathurin
Copy link

This was found in #733 which is failing CI because the graveyard creation is slow

In the end it wasn't because of that, still this is a great improvement.

@RemDelaporteMathurin RemDelaporteMathurin added the enhancement New feature or request label Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants