Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert error_handling.f90 to Python #3394

Open
Tracked by #2896
timothy-nunn opened this issue Nov 13, 2024 · 1 comment
Open
Tracked by #2896

Convert error_handling.f90 to Python #3394

timothy-nunn opened this issue Nov 13, 2024 · 1 comment
Assignees
Labels
Blocked Issues that can't be worked on due to another issue needing to be resolved first

Comments

@timothy-nunn
Copy link
Contributor

timothy-nunn commented Nov 13, 2024

Convert the error handling system to Python. Separate the system in two:

  1. Exception handling: a hierarchy of PROCESS errors that replace level 3 errors
  2. Warning handling: a system to record warnings and diagnostics to be displayed at the end of a PROCESS run

Exception handling

Provide a parent ProcessException object

  • This will allow PROCESS-thrown errors to be easily caught by internal and external code
  • Diagnostics can be attached directly to the error

Additional, more specific, exceptions? (e.g. ProcessValueError).

Warning handling

Handled by a central object attached directly to the models?
No more warning IDs. Duplicate warnings are identified by comparing the message directly.
Diagnostics are attached directly to the warning (as a dictionary?)
Report at the end as currently.

Blocked by constraint_equations.f90, evaluators.f90, init_module.f90, initial.f90, iteration_variables.f90, main_module.f90, scan.f90

@timothy-nunn timothy-nunn self-assigned this Nov 13, 2024
@timothy-nunn timothy-nunn added the Blocked Issues that can't be worked on due to another issue needing to be resolved first label Nov 13, 2024
@timothy-nunn
Copy link
Contributor Author

Will also allow the remove of fson.f90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked Issues that can't be worked on due to another issue needing to be resolved first
Projects
None yet
Development

No branches or pull requests

1 participant