Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test_solver #3140

Closed
mkovari opened this issue Apr 17, 2024 · 0 comments · Fixed by #3423
Closed

Remove test_solver #3140

mkovari opened this issue Apr 17, 2024 · 0 comments · Fixed by #3423
Assignees

Comments

@mkovari
Copy link
Collaborator

mkovari commented Apr 17, 2024

The routine test_solver in the integration tests takes a long time to run. Moreover, I don't know that it is very useful. Tim's comments in the code:
# TODO: I'm not sure how useful this test is anymore? TN
and at the end,
# TODO This might need to assert something, like ifail == 1?

Doc string:

Code to test PROCESS Solver by choosing different starting values
    for the iteration parameters around the initial values in the INPUT file
    Code modified by Sarah Medley in April 2015 to also calculate Q (fusion power/
    injected power) and output this to SolverTest.out

For the moment I will change the NITER, the number of times PROCESS is run, from 10 to 1 in integration/data/test_solver.conf.
Would anyone complain if I remove the test completely?
@timothy-nunn @jonmaddock @jmorris-uk

@jonmaddock jonmaddock self-assigned this Jul 2, 2024
@timothy-nunn timothy-nunn linked a pull request Dec 12, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants