Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression test overwriting #3043

Closed
timothy-nunn opened this issue Feb 1, 2024 · 3 comments
Closed

Regression test overwriting #3043

timothy-nunn opened this issue Feb 1, 2024 · 3 comments

Comments

@timothy-nunn
Copy link
Contributor

We need to decide on how we will deal with regression test assets changing in PROCESS.

I believe we could have a GitHub workflow that overwrites and commits the test assets to the branch before merging?

@timothy-nunn
Copy link
Contributor Author

Possibly running a pipeline on workflow approval would work. This would then commit back to the branch (🤢) with an overwrite of the reference files. This would cause another run of the workflow that, this time, wont need to run the overwriting job

@timothy-nunn
Copy link
Contributor Author

I have added a merge requirement that the tests must all be passing before merge which will require a failing regression test is corrected before a merge is allowed. This does not guarantee that changes on main won't still break the regression tests, but its a start?

@timothy-nunn
Copy link
Contributor Author

Closing in favour of #2915

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant