Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): new auth with cert service #649

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

marianfoo
Copy link
Member

first PoC to authenticate with a SAP Passport Certificate to BTP using playwright and abstraction package playwright-client-certificate-login
currently, to make this work, put pfx file to folder ui5-ts-app and rename it to sap.pfx and put your passphrase to in the CertAuthenticator.ts and run npm run authentication:btp.

This is just a PoC, needs better testing cases and proper config handling in the CertAuthenticator.ts.
Still work to do but it works locally, should also work on pipelines

@marianfoo marianfoo changed the title feat(auth): first PoC with Cert Auth to BTP feat(auth): new auth with cert service Nov 8, 2024
@christian-bromann
Copy link

This automation done in playwright-client-certificate-login can be easily done in WebdriverIO as well, allowing you to avoid the additional dependency to Playwright. Wdyt?

@marianfoo
Copy link
Member Author

This automation done in playwright-client-certificate-login can be easily done in WebdriverIO as well, allowing you to avoid the additional dependency to Playwright. Wdyt?

I haven't seen any example of it. Can you show me a demo or documentation ?

@christian-bromann
Copy link

@marianfoo sorry I was a bit to quick to judge here. It is currently not as easy to do it with WebDriver.

@marianfoo
Copy link
Member Author

marianfoo commented Nov 15, 2024

@marianfoo sorry I was a bit to quick to judge here. It is currently not as easy to do it with WebDriver.

@christian-bromann
we tried setting the certificate with pk12util but it just did not work, locally and in the pipeline. Using the new feature from playwright i just so much easier and it just works.
It would be great to have this feature in WebdriverIO for tests, till then i´ll use Playwright.

@marianfoo marianfoo requested a review from Siolto November 26, 2024 08:09
@marianfoo
Copy link
Member Author

@vobu @Siolto
any capacity to review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants