Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(uiSref): run update when input properties change #141

Merged
merged 3 commits into from
Sep 14, 2017
Merged

fix(uiSref): run update when input properties change #141

merged 3 commits into from
Sep 14, 2017

Conversation

jonrimmer
Copy link
Contributor

Fixes #140

/**
* `@Input('uiSref')` The name of the state to link to
*
* ```html
* <a uiSref="hoome">Home</a>
* ```
*/
@Input('uiSref') state: string;
@Input('uiSref')
get state(): string {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to keep the old way and relying to ngOnChanges unstead

@jonrimmer
Copy link
Contributor Author

@aitboudad I've done as you suggested. This does require keeping the .update() call in each of the internal API setters.

Copy link
Contributor

@aitboudad aitboudad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christopherthielen christopherthielen merged commit 9ecc6e2 into ui-router:master Sep 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants