-
Notifications
You must be signed in to change notification settings - Fork 136
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(lazyLoad): fixed getting parent injector in angular 4.2
- Loading branch information
1 parent
543afcd
commit dcd1cda
Showing
1 changed file
with
2 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcd1cda
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So ui-router is broken for angular 4.2 without this, but no one actually cares about that much to push new npm release. 👎
dcd1cda
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you silly? I'm still gonna send it
dcd1cda
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably. I just upgraded to 4.2, and now I see that I need to rollback because of no way for me to apply that patch in my automated docker workflow. Seeing that fix is actually works and one thing that holds me back is npm release of let's say beta7 makes me feel really strange.