Run only required synchronous onBefore hooks
#2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added tests to make sure I did not break |
christopherthielen
requested changes
Oct 21, 2016
| * Run all TransitionHooks, ignoring their return value. | ||
| */ | ||
| static runAllHooks(hooks: TransitionHook[]): void { | ||
| hooks.map(hook => { |
There was a problem hiding this comment.
Can you change this to forEach
There was a problem hiding this comment.
Yeah, makes sense. Fixed.
| errorHandler(exception); | ||
| // Break on first thrown error or false/TargetState | ||
| if (Rejection.isTransitionRejectionPromise(hookResult)) { | ||
| return hookResult; |
There was a problem hiding this comment.
I think this block could read a little nicer like so:
for (let hook of hooks) {
try {
let hookResult = hook.invokeHook();
if (Rejection.isTransitionRejectionPromise(hookResult)) {
// Break on first thrown error or false/TargetState
return hookResult;
}
results.push(hookResult);
} catch (exception) {
return Rejection.errored(exception).toPromise();
}
}There was a problem hiding this comment.
I thought it improved from before, but this is even nicer. No need to check for TransitionRejection for known errors. Fixed.
| @@ -317,7 +372,9 @@ describe('transition', function () { | |||
| .then(done); | |||
| })); | |||
|
|
|||
| it('should be called even if other .onSuccess() callbacks fail (throw errors, etc)', ((done) => { | |||
| it('should call all .onSuccess() even when callbacks fail (throw errors, etc)', ((done) => { | |||
There was a problem hiding this comment.
lovely, thanks for adding these tests
There was a problem hiding this comment.
I was worried about breaking existing functionality, so I thought it best to make sure :)
| @@ -364,6 +421,33 @@ describe('transition', function () { | |||
| .then(() => expect(hooks).toEqual([ 'splatsplat', 'AD' ])) | |||
| .then(done); | |||
| })); | |||
|
|
|||
| it('should call all error handlers when transition fails.', ((done) => { | |||
first hook that modifies the transition. updated request changes
christopherthielen
approved these changes
Oct 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to solve the issue discussed in angular-ui/ui-router#3091