chore(test): Eagerly bind the urlService in the TestPlugin.

feat(UrlService): allow eager or lazy binding of location objects during construction
ui-router · Jan 5, 2017 · 7e0a8af · 7e0a8af
1 parent 1ca93d0
commit 7e0a8af
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/url/urlService.ts b/src/url/urlService.ts
@@ -82,17 +82,17 @@ export class UrlService implements LocationServices, UrlSyncApi {
   private router: UIRouter;
 
   /** @hidden */
-  constructor(router: UIRouter) {
+  constructor(router: UIRouter, lateBind = true) {
     this.router = router;
     this.rules = {} as any;
     this.config = {} as any;
 
     // proxy function calls from UrlService to the LocationService/LocationConfig
     const locationServices = () => router.locationService;
-    createProxyFunctions(locationServices, this, locationServices, locationServicesFns, true);
+    createProxyFunctions(locationServices, this, locationServices, locationServicesFns, lateBind);
 
     const locationConfig = () => router.locationConfig;
-    createProxyFunctions(locationConfig, this.config, locationConfig, locationConfigFns, true);
+    createProxyFunctions(locationConfig, this.config, locationConfig, locationConfigFns, lateBind);
 
     const umf = () => router.urlMatcherFactory;
     createProxyFunctions(umf, this.config, umf, umfFns);

diff --git a/test/_testingPlugin.ts b/test/_testingPlugin.ts
@@ -1,6 +1,7 @@
 import { UIRouter } from "../src/router";
 import { UIRouterPluginBase } from "../src/interface";
 import * as vanilla from "../src/vanilla";
+import { UrlService } from "../src/url/urlService";
 
 export class TestingPlugin extends UIRouterPluginBase {
   name: string = 'testing';
@@ -11,6 +12,8 @@ export class TestingPlugin extends UIRouterPluginBase {
     super();
     router.plugin(vanilla.servicesPlugin);
     router.plugin(vanilla.memoryLocationPlugin);
+    // bind the location proxy functions immediately
+    router.urlService = new UrlService(router, false);
 
     this.addErrorLoopHandler();