Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly declared component bindings should always be mapped #45

Closed
christopherthielen opened this issue Feb 10, 2017 · 0 comments
Closed

Comments

@christopherthielen
Copy link
Member

related to #36

If a state has explicitly defined mappings, we currently only apply those mappings if we find a matching @Input() or inputs: [] metadata. Because decorators are now being stripped for AoT compile, there is no longer any way to be certain that the property exists on the component or not.

For now, we should always set the property on the component (if an explicit binding is made), even if the metadata is not found.

var state = {
  resolve: [ { token: 'fooData', resolveFn: getFoo } ],
  component: FooComponent,
  bindings: { fooData: 'fooData' },
}

cc @aitboudad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant