Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-enable c48-5deg warmstart test #1822

Closed
DeniseWorthen opened this issue Jul 5, 2023 · 7 comments · Fixed by #2235
Closed

re-enable c48-5deg warmstart test #1822

DeniseWorthen opened this issue Jul 5, 2023 · 7 comments · Fixed by #2235
Assignees
Labels
enhancement New feature or request

Comments

@DeniseWorthen
Copy link
Collaborator

DeniseWorthen commented Jul 5, 2023

Description

The C48-5deg warmstart test was disabled in PR #1812. It needs to be re-enabled.

Solution

Once PR #1777 and #1807 are merged, a new set of warm start ICs should be created and added to the input-data directory. This will allow the test to be re-enabled.

Alternatives

Related to

@DeniseWorthen
Copy link
Collaborator Author

@NickSzapiro-NOAA Are you able to work on this now? I want to include the required files in the input-data update I will be making for the Bu angle fix.

We need new ICs (really warmstart) files at 2021032306. You can see the required files in the existing input-data directories for CICE,MOM6,CMEPS and FV3_input_data48/INPUT_L127_mx500.

These are generated by running the cpld_control_c48 at the current develop. Once you have them generated, I will populate the new input-data directory I have you can confirm that the warmstart test runs. We'll then have to verify the restart-from-warmstart test also passes.

@NickSzapiro-NOAA
Copy link
Collaborator

@DeniseWorthen restarts from cpld_control_c48 are available on hera at /scratch1/NCEPDEV/nems/Nick.Szapiro/tasks/warmStart_c48-5deg/IC
Please let me know if you'd like me to rename/arrange

@DeniseWorthen
Copy link
Collaborator Author

@NickSzapiro-NOAA Thanks. I've repopulated the input-data directory here /scratch1/NCEPDEV/stmp4/Denise.Worthen/input-data_20240501

Now can you re-enable the two c48 cpld tests (warmstart and restart) and create a warm start baseline after pointing to this location for the input and verify both the warm and restart tests pass?

@NickSzapiro-NOAA
Copy link
Collaborator

cpld*c48 tests now pass on hera. See /scratch1/NCEPDEV/nems/Nick.Szapiro/tasks/warmStart_c48-5deg/ufs-weather-model/tests

@junwang-noaa
Copy link
Collaborator

@NickSzapiro-NOAA are you going to create a UFS WM PR to include the tests in RT?

@NickSzapiro-NOAA
Copy link
Collaborator

@junwang-noaa I think @DeniseWorthen already did in #2235

@DeniseWorthen
Copy link
Collaborator Author

Yes, because re-enabling the test requires new input data, I added it to the PR which will fix input grid data for CICE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants