Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent overlapping annotations from LLM evaluators #111

Open
kasnerz opened this issue Oct 7, 2024 · 1 comment
Open

Prevent overlapping annotations from LLM evaluators #111

kasnerz opened this issue Oct 7, 2024 · 1 comment
Assignees
Labels
bug Something isn't working in progress Working on it!

Comments

@kasnerz
Copy link
Collaborator

kasnerz commented Oct 7, 2024

We have no way to prevent LLMs from producing annotations that overlap.

Since we decided not to support that (#31), we should modify the matching algorithm to disallow overlapping spans. Possible solutions include:

  • trimming the suffix of the preceding annotation,
  • trimming the prefix of the follow-up annotation,
  • skipping the overlapping annotation.
@kasnerz kasnerz added the bug Something isn't working label Oct 7, 2024
@kasnerz kasnerz added wontfix This will not be worked on bug Something isn't working and removed bug Something isn't working wontfix This will not be worked on labels Oct 25, 2024
@kasnerz
Copy link
Collaborator Author

kasnerz commented Oct 25, 2024

Update: In general, our matching algorithm ensures that no annotations overlap.

The only thing that is required is preventing matching from scratch. The purpose of this extra tweak was to "save" incorrectly ordered annotations which would otherwise be lost.

But since the feature is undocumented, it makes sense to remove it. It is already removed in the upcoming feature pack:

# if current_pos != 0 and start_pos == -1:

@kasnerz kasnerz self-assigned this Oct 25, 2024
@kasnerz kasnerz added the in progress Working on it! label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working in progress Working on it!
Projects
None yet
Development

No branches or pull requests

1 participant