Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind commands to event.keyCode instead of letters #147

Open
2 tasks done
InvisibleRain opened this issue May 11, 2023 · 0 comments
Open
2 tasks done

Bind commands to event.keyCode instead of letters #147

InvisibleRain opened this issue May 11, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@InvisibleRain
Copy link

InvisibleRain commented May 11, 2023

The issue is already reported or known issue?

  • I have searched the existing issues on github
  • I am using the latest version

Description

Keymaps don't work when using a non-English keyboard layout (e.g. Russian). A dirty workaround is to duplicate all the keymaps in the config and replace the English letters with letters of another language. Another way to fix this, would be to use KeyboardEvent.code instead of KeyboardEvent.key in InputDriver.ts

This is a feature request instead of a bug report because, despite improving UX for most users, such a change may break existing installations for AZERTY or QWERTZ users. So, the best way would be to make this feature optional under the properties section.

Other details

Users asking for the feature: ueokande/vim-vixen#1442

@InvisibleRain InvisibleRain added the enhancement New feature or request label May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant