Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): setNodeSelection should not clamp pos by Selection.atStart/atEnd #3091

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

kivikakk
Copy link
Contributor

Fixes #3090.

This doesn't regress #1588, as that bug was only in the focus command.

@netlify
Copy link

netlify bot commented Aug 16, 2022

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit ddac68c
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/62fb37fc519045000aa87f28
😎 Deploy Preview https://deploy-preview-3091--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@bdbch bdbch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks

@bdbch bdbch merged commit 313b8b8 into ueberdosis:main Aug 22, 2022
@kivikakk kivikakk deleted the node-selection-bounds branch December 6, 2022 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setNodeSelection(non-leaf first node in doc with text) can create a NodeSelection for text
2 participants