Editable state isn't reactive

[chrispiech]

What’s the bug you are facing?

Changing the editor state (for example):
editor.setEditable

Doesn't creative a reactive change to
props.editor.isEditable

Which prevents Nodes from reacting to a change to the editable state

Which browser was this experienced in? Are any special extensions installed?

all!

How can we reproduce the bug on our side?

Create an editor
Create a custom Node
editor.setEditable(false)
Notice that code in the Node
useEffect(()=> {
alert('test')
}, [props.editor.isEditable])
is not fired

Can you provide a CodeSandbox?

No response

What did you expect to happen?

I expected it to have a reactive state change

Anything to add? (optional)

No response

Did you update your dependencies?

• Yes, I’ve updated my dependencies to use the latest version of all packages.

Are you sponsoring us?

• Yes, I’m a sponsor. 💖

[Dreched]

A CodeSandbox reproducing the issue is located here.

[bdbch]

Hey @chrispiech @Dreched

While the isEditable value is not reactive by default, I pushed a change (see #2935) that should allow you to track the state of the editors editable state on your own.

It could look something like this:

const [isEditable, setIsEditable] = useState(false)

const editor = useEditor(
  ...
  onUpdate(props) {
    setIsEditable(props.editor.isEditable)
  }
)

You can then use that state to make all of your components reactive (for example via context or any other state management solution).

[github-actions]

This issue is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 7 days

[i-am-the-slime]

Is this meant to work now or did this just get closed because it was stale for a week?