Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Version broke custom extension #2073

Closed
1 of 2 tasks
eddbbt opened this issue Oct 22, 2021 · 3 comments
Closed
1 of 2 tasks

New Version broke custom extension #2073

eddbbt opened this issue Oct 22, 2021 · 3 comments
Labels
Type: Bug The issue or pullrequest is related to a bug

Comments

@eddbbt
Copy link

eddbbt commented Oct 22, 2021

What’s the bug you are facing?

Last version released (2.0.0-beta.126) broke compatibilty with my company custom extensions, that were running good with previous relese (2.0.0-beta.113). We've just noticed that after an npm install.

Following the fresh error
immagine

I don't even know what that means, and 'm not going to investigate this, all I know is that the first time this incident happened I've had to rewrite our custom extensions.
You cannot sponsor tiptap as

Create exactly the rich text editor you want out of customizable building blocks. Tiptap comes with sensible defaults, a lot of extensions and a friendly API to customize every aspect.

if you keep broke the sistem behind custom extensions, can you?

We had to rollback to version 2.0.0-beta.113.

Thanks

How can we reproduce the bug on our side?

-Install version 2.0.0-beta.113
-Write your own custom extension with old sintax
-run npm install
-tiptap core update to 2.0.0-beta.126
-everithing broken now

Can you provide a CodeSandbox?

No response

What did you expect to happen?

That everything works in a consistent way from version to version

Anything to add? (optional)

No response

Did you update your dependencies?

  • Yes, I’ve updated my dependencies to use the latest version of all packages.

Are you sponsoring us?

  • Yes, I’m a sponsor. 💖
@eddbbt eddbbt added the Type: Bug The issue or pullrequest is related to a bug label Oct 22, 2021
@philippkuehn
Copy link
Contributor

if you keep broke the sistem behind custom extensions, can you?

Did you see that beta badge? But of course you don't have to update either.

About your issue: See this PR for more details: #1997

@eddbbt
Copy link
Author

eddbbt commented Oct 27, 2021

@philippkuehn maybe you need to keep a changelog, won't be super useful? PR and github issue is not a replacement for a well written changelog, especially for breaking changes.
Today, 27/10/2021 the page https://tiptap.dev/changelog is still empty, that's a shame.
That possibly avoid future issues like mine, and looking at PR 1997, many others.

@philippkuehn
Copy link
Contributor

Of course you can follow the changelogs within the package folders.
For example: https://github.com/ueberdosis/tiptap/blob/main/packages/core/CHANGELOG.md

https://tiptap.dev/changelog is still empty, that's a shame.

You don’t have to use this package 👋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug The issue or pullrequest is related to a bug
Projects
None yet
Development

No branches or pull requests

2 participants