From fc67cb1b7166c1ab6b6e0174539c9e29c364eace Mon Sep 17 00:00:00 2001 From: Dominik Biedebach Date: Thu, 30 Nov 2023 17:54:06 +0100 Subject: [PATCH] fix(core): fix options now being empty --- packages/core/src/Extension.ts | 4 ++-- packages/core/src/Mark.ts | 4 ++-- packages/core/src/Node.ts | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/core/src/Extension.ts b/packages/core/src/Extension.ts index 27decb0d8b9..e13f4bf6be9 100644 --- a/packages/core/src/Extension.ts +++ b/packages/core/src/Extension.ts @@ -297,7 +297,7 @@ export class Extension { config: ExtensionConfig = { name: this.name, - defaultOptions: undefined, + defaultOptions: {}, } constructor(config: Partial> = {}) { @@ -308,7 +308,7 @@ export class Extension { this.name = this.config.name - if (config.defaultOptions) { + if (config.defaultOptions && Object.keys(config.defaultOptions).length > 0) { console.warn( `[tiptap warn]: BREAKING CHANGE: "defaultOptions" is deprecated. Please use "addOptions" instead. Found in extension: "${this.name}".`, ) diff --git a/packages/core/src/Mark.ts b/packages/core/src/Mark.ts index c6e4ac890f9..3d56c85d261 100644 --- a/packages/core/src/Mark.ts +++ b/packages/core/src/Mark.ts @@ -429,7 +429,7 @@ export class Mark { config: MarkConfig = { name: this.name, - defaultOptions: undefined, + defaultOptions: {}, } constructor(config: Partial> = {}) { @@ -440,7 +440,7 @@ export class Mark { this.name = this.config.name - if (config.defaultOptions) { + if (config.defaultOptions && Object.keys(config.defaultOptions).length > 0) { console.warn( `[tiptap warn]: BREAKING CHANGE: "defaultOptions" is deprecated. Please use "addOptions" instead. Found in extension: "${this.name}".`, ) diff --git a/packages/core/src/Node.ts b/packages/core/src/Node.ts index 6ca5bbd5a68..c478992d295 100644 --- a/packages/core/src/Node.ts +++ b/packages/core/src/Node.ts @@ -538,7 +538,7 @@ export class Node { config: NodeConfig = { name: this.name, - defaultOptions: undefined, + defaultOptions: {}, } constructor(config: Partial> = {}) { @@ -549,7 +549,7 @@ export class Node { this.name = this.config.name - if (config.defaultOptions) { + if (config.defaultOptions && Object.keys(config.defaultOptions).length > 0) { console.warn( `[tiptap warn]: BREAKING CHANGE: "defaultOptions" is deprecated. Please use "addOptions" instead. Found in extension: "${this.name}".`, )