Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warnings based on 1.14-dev. #702

Merged
merged 4 commits into from
Sep 2, 2022

Conversation

crova
Copy link
Contributor

@crova crova commented Aug 10, 2022

Greetings, how is it going?

As mentioned on this issue there are a few warnings when compiling while using elixir 1.14.

Besides those that were mentioned, when useing Guardian on a module, the following warn would raise:

warning: Application.get_env/3 is discouraged in the module body, use Application.compile_env/3 instead

This PR address both issues.

Please let me know if I should improve this PR somehow.

Cheers.

@crova crova requested a review from a team as a code owner August 10, 2022 13:22
@gungorkocak
Copy link

I'm also trying to upgrade Elixir v1.14.0-rc.1 and facing the same deprecation warning with Application.get_env/3.

Also mix compile --force --warnings-as-errors is a requirement for me(i.e. CI pipeline).
That ties upgrading Elixir to this PR (or a better solution).

@kevinkirkup
Copy link

Related to #704

@yordis yordis merged commit cdfdd3a into ueberauth:master Sep 2, 2022
@yordis
Copy link
Member

yordis commented Sep 2, 2022

💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants