-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
impl Map::retain
and Set::retain
#27
Conversation
test examples and benches in CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Retain impl LGTM, I'd like the examples to be cleaner though. Easiest would be to only build examples with the full set of features (and no need to #[test]
them).
bac123c
to
b0885ab
Compare
Understood on the examples, but can you restore the one you deleted ( |
Ah. Not sure I want to have a permanent example for this since they're meant to be demonstrative uses of the library. 🤔 What if we keep it as a test? Then you can run it with |
The |
All right, with this you can now check all expansions with:
Be warned: it's VERY noisy. :) Does that work for you? |
That works, thanks |
also test examples and benches in CI
relates #11