Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Innaccuracies at extreme latitudes #17

Open
markmcconnell opened this issue Dec 12, 2020 · 0 comments
Open

Innaccuracies at extreme latitudes #17

markmcconnell opened this issue Dec 12, 2020 · 0 comments

Comments

@markmcconnell
Copy link

During calculate(), when cosLocalHourAngle > 1 or < -1, then the sun does not actually rise or set at the location on the given day. It would be nice if the library provided some optional way to detect this, perhaps by returning null or throwing an error in these conditions.

Otherwise, this is perfect. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant