Pypsa model #19

samgdotson · 2024-09-20T14:57:44Z

This PR adds a PyPSA base model.

Closes Create a PyPSA base model #3
Closes Add GitHub CI workflow #18

…ng type

pep8speaks · 2024-09-20T14:57:57Z

Hello @samgdotson! Thanks for updating this PR.

In the file functions/nrel_data_api.py:

Line 11:27: E231 missing whitespace after ':'
Line 12:24: E231 missing whitespace after ':'
Line 13:26: E231 missing whitespace after ':'
Line 14:31: E231 missing whitespace after ':'
Line 15:25: E231 missing whitespace after ':'
Line 16:32: E231 missing whitespace after ':'
Line 19:20: E231 missing whitespace after ':'
Line 20:20: E231 missing whitespace after ':'
Line 21:21: E231 missing whitespace after ':'
Line 22:25: E231 missing whitespace after ':'
Line 23:25: E231 missing whitespace after ':'
Line 24:20: E231 missing whitespace after ':'
Line 25:25: E231 missing whitespace after ':'
Line 26:26: E231 missing whitespace after ':'
Line 54:51: E251 unexpected spaces around keyword / parameter equals
Line 54:53: E251 unexpected spaces around keyword / parameter equals
Line 55:51: E251 unexpected spaces around keyword / parameter equals
Line 55:53: E251 unexpected spaces around keyword / parameter equals
Line 63:62: E127 continuation line over-indented for visual indent
Line 128:11: E225 missing whitespace around operator
Line 159:15: W292 no newline at end of file

In the file scripts/calculate_historical_expenses.py:

Line 5:1: W293 blank line contains whitespace
Line 7:1: W293 blank line contains whitespace
Line 8:31: E231 missing whitespace after ':'
Line 8:57: W291 trailing whitespace
Line 9:17: E128 continuation line under-indented for visual indent
Line 9:29: E231 missing whitespace after ':'
Line 10:17: E128 continuation line under-indented for visual indent
Line 10:25: E231 missing whitespace after ':'
Line 11:17: E128 continuation line under-indented for visual indent
Line 11:27: E231 missing whitespace after ':'
Line 12:17: E128 continuation line under-indented for visual indent
Line 12:27: E231 missing whitespace after ':'
Line 13:17: E128 continuation line under-indented for visual indent
Line 13:33: E231 missing whitespace after ':'
Line 14:1: W293 blank line contains whitespace
Line 16:1: W293 blank line contains whitespace
Line 17:29: E231 missing whitespace after ','
Line 17:42: E231 missing whitespace after ','
Line 17:55: E231 missing whitespace after ','
Line 17:69: E231 missing whitespace after ','
Line 17:101: E501 line too long (101 > 100 characters)
Line 18:1: W293 blank line contains whitespace
Line 20:1: W293 blank line contains whitespace
Line 21:57: W292 no newline at end of file

In the file scripts/calculate_res_structures.py:

Line 8:1: W293 blank line contains whitespace
Line 9:1: W293 blank line contains whitespace
Line 10:5: E303 too many blank lines (2)
Line 13:1: W293 blank line contains whitespace
Line 17:21: E127 continuation line over-indented for visual indent
Line 19:39: E231 missing whitespace after ':'

In the file scripts/calculate_residential_load.py:

Line 6:1: W293 blank line contains whitespace
Line 10:19: E226 missing whitespace around arithmetic operator
Line 10:29: W291 trailing whitespace
Line 11:26: E226 missing whitespace around arithmetic operator
Line 12:1: W293 blank line contains whitespace
Line 17:1: W293 blank line contains whitespace
Line 20:1: W293 blank line contains whitespace
Line 21:1: W293 blank line contains whitespace
Line 22:5: E303 too many blank lines (2)
Line 22:64: E231 missing whitespace after ','
Line 22:72: E225 missing whitespace around operator
Line 23:26: E128 continuation line under-indented for visual indent
Line 23:76: E226 missing whitespace around arithmetic operator
Line 24:1: W293 blank line contains whitespace
Line 28:1: W293 blank line contains whitespace
Line 29:41: E226 missing whitespace around arithmetic operator
Line 30:41: E226 missing whitespace around arithmetic operator
Line 31:1: W293 blank line contains whitespace
Line 34:1: W293 blank line contains whitespace
Line 35:1: W293 blank line contains whitespace
Line 36:1: W293 blank line contains whitespace
Line 37:1: E303 too many blank lines (3)
Line 37:1: W293 blank line contains whitespace
Line 37:1: W391 blank line at end of file

In the file scripts/retrieve_cejst_data.py:

Line 25:77: W292 no newline at end of file

In the file scripts/retrieve_census_data.py:

Line 75:30: E231 missing whitespace after ','
Line 76:61: E231 missing whitespace after ','
Line 80:58: E226 missing whitespace around arithmetic operator
Line 81:1: W293 blank line contains whitespace

In the file scripts/retrieve_community_cutout.py:

Line 17:32: E231 missing whitespace after ','
Line 17:43: E231 missing whitespace after ','
Line 18:1: W293 blank line contains whitespace
Line 20:1: W391 blank line at end of file

In the file scripts/retrieve_lead_data.py:

Line 26:5: E303 too many blank lines (2)
Line 28:1: W293 blank line contains whitespace
Line 30:1: W293 blank line contains whitespace
Line 33:1: W293 blank line contains whitespace
Line 35:1: W293 blank line contains whitespace
Line 36:44: E225 missing whitespace around operator
Line 37:1: W293 blank line contains whitespace
Line 38:59: W292 no newline at end of file

In the file scripts/retrieve_nrel_costs.py:

Line 11:25: E126 continuation line over-indented for hanging indent
Line 11:48: E225 missing whitespace around operator
Line 12:25: W503 line break before binary operator
Line 12:26: E225 missing whitespace around operator
Line 12:38: E225 missing whitespace around operator
Line 13:25: W503 line break before binary operator
Line 13:26: E225 missing whitespace around operator
Line 13:41: E225 missing whitespace around operator
Line 14:25: W503 line break before binary operator
Line 14:26: E225 missing whitespace around operator
Line 14:41: E225 missing whitespace around operator
Line 15:25: W503 line break before binary operator
Line 15:26: E225 missing whitespace around operator
Line 15:53: E225 missing whitespace around operator
Line 16:25: W503 line break before binary operator
Line 16:26: E225 missing whitespace around operator
Line 16:40: E225 missing whitespace around operator
Line 17:25: W503 line break before binary operator
Line 17:26: E225 missing whitespace around operator
Line 17:41: E225 missing whitespace around operator
Line 18:25: W503 line break before binary operator
Line 18:26: E225 missing whitespace around operator
Line 19:25: E123 closing bracket does not match indentation of opening bracket's line
Line 24:1: W293 blank line contains whitespace
Line 25:47: W292 no newline at end of file

In the file scripts/retrieve_outage_data.py:

Line 5:21: E231 missing whitespace after ':'
Line 6:21: E231 missing whitespace after ':'
Line 7:21: E231 missing whitespace after ':'
Line 8:21: E231 missing whitespace after ':'
Line 9:21: E231 missing whitespace after ':'
Line 10:21: E231 missing whitespace after ':'
Line 26:52: W292 no newline at end of file

In the file scripts/retrieve_project_sunroof.py:

Line 23:1: W293 blank line contains whitespace
Line 24:1: W293 blank line contains whitespace
Line 25:5: E265 block comment should start with '# '
Line 25:5: E303 too many blank lines (2)
Line 28:1: W293 blank line contains whitespace
Line 29:1: W293 blank line contains whitespace
Line 30:5: E303 too many blank lines (2)
Line 31:1: W293 blank line contains whitespace
Line 31:1: W391 blank line at end of file

In the file scripts/retrieve_pums_data.py:

Line 7:1: W293 blank line contains whitespace
Line 8:1: W293 blank line contains whitespace
Line 9:5: E303 too many blank lines (2)
Line 14:1: W293 blank line contains whitespace
Line 16:1: W293 blank line contains whitespace
Line 17:1: W293 blank line contains whitespace
Line 18:5: E303 too many blank lines (2)
Line 20:54: E225 missing whitespace around operator
Line 20:67: E502 the backslash is redundant between brackets
Line 21:141: W292 no newline at end of file

In the file scripts/retrieve_renewables.py:

Line 15:1: E302 expected 2 blank lines, found 1
Line 29:41: E127 continuation line over-indented for visual indent
Line 30:41: E127 continuation line over-indented for visual indent
Line 32:1: W293 blank line contains whitespace
Line 35:35: E231 missing whitespace after ','
Line 36:35: E231 missing whitespace after ','
Line 36:43: E231 missing whitespace after ','
Line 36:49: E231 missing whitespace after ','
Line 36:56: E231 missing whitespace after ','
Line 36:66: E231 missing whitespace after ','
Line 37:5: E722 do not use bare 'except'
Line 39:1: W293 blank line contains whitespace
Line 41:1: W293 blank line contains whitespace
Line 52:1: W293 blank line contains whitespace
Line 60:41: E231 missing whitespace after ','
Line 60:45: E231 missing whitespace after ','
Line 65:54: W291 trailing whitespace
Line 66:29: E128 continuation line under-indented for visual indent
Line 68:51: E231 missing whitespace after ','
Line 68:59: E231 missing whitespace after ','
Line 68:65: E231 missing whitespace after ','
Line 68:72: E231 missing whitespace after ','
Line 69:41: E231 missing whitespace after ','
Line 69:49: E231 missing whitespace after ','
Line 69:55: E231 missing whitespace after ','
Line 69:62: E231 missing whitespace after ','
Line 71:1: W293 blank line contains whitespace
Line 74:65: W291 trailing whitespace
Line 79:1: W293 blank line contains whitespace
Line 97:13: E117 over-indented
Line 98:1: W293 blank line contains whitespace
Line 99:17: W291 trailing whitespace
Line 101:1: E305 expected 2 blank lines after class or function definition, found 1
Line 102:1: W293 blank line contains whitespace
Line 104:1: W293 blank line contains whitespace
Line 108:38: W292 no newline at end of file

In the file scripts/retrieve_res_load.py:

Line 30:25: E127 continuation line over-indented for visual indent
Line 31:25: E127 continuation line over-indented for visual indent
Line 32:25: E127 continuation line over-indented for visual indent
Line 33:25: E127 continuation line over-indented for visual indent
Line 34:25: E124 closing bracket does not match visual indentation
Line 52:1: W293 blank line contains whitespace
Line 54:31: W291 trailing whitespace
Line 55:17: E128 continuation line under-indented for visual indent
Line 55:27: W291 trailing whitespace
Line 56:17: E128 continuation line under-indented for visual indent
Line 57:17: E128 continuation line under-indented for visual indent
Line 57:30: W291 trailing whitespace
Line 58:17: E128 continuation line under-indented for visual indent
Line 59:17: E128 continuation line under-indented for visual indent
Line 59:23: W291 trailing whitespace
Line 60:17: E128 continuation line under-indented for visual indent
Line 61:17: E128 continuation line under-indented for visual indent
Line 63:66: W291 trailing whitespace
Line 64:45: W291 trailing whitespace
Line 70:1: W293 blank line contains whitespace
Line 75:1: W293 blank line contains whitespace
Line 79:1: W293 blank line contains whitespace
Line 80:1: W293 blank line contains whitespace
Line 81:5: E303 too many blank lines (2)
Line 93:49: E225 missing whitespace around operator
Line 93:62: W291 trailing whitespace
Line 94:33: E127 continuation line over-indented for visual indent
Line 94:33: W503 line break before binary operator
Line 94:61: E225 missing whitespace around operator
Line 94:101: E501 line too long (110 > 100 characters)
Line 95:35: E231 missing whitespace after ','
Line 96:35: E231 missing whitespace after ','
Line 100:5: E303 too many blank lines (2)
Line 103:1: W293 blank line contains whitespace
Line 106:1: W293 blank line contains whitespace
Line 113:1: W293 blank line contains whitespace
Line 118:66: W291 trailing whitespace
Line 119:41: E128 continuation line under-indented for visual indent
Line 119:65: W291 trailing whitespace
Line 120:41: E128 continuation line under-indented for visual indent
Line 121:44: W291 trailing whitespace
Line 125:1: W293 blank line contains whitespace
Line 129:1: W293 blank line contains whitespace
Line 130:55: E231 missing whitespace after ':'
Line 131:1: W293 blank line contains whitespace
Line 132:55: E231 missing whitespace after ':'
Line 133:1: W293 blank line contains whitespace
Line 136:1: W293 blank line contains whitespace
Line 139:1: W293 blank line contains whitespace
Line 142:1: W293 blank line contains whitespace
Line 142:1: W391 blank line at end of file

In the file scripts/retrieve_shapefiles.py:

Line 7:26: E231 missing whitespace after ':'
Line 8:13: E231 missing whitespace after ':'
Line 9:21: E231 missing whitespace after ':'
Line 10:14: E231 missing whitespace after ':'
Line 11:28: E231 missing whitespace after ':'
Line 12:24: E231 missing whitespace after ':'
Line 13:12: E231 missing whitespace after ':'
Line 17:1: W293 blank line contains whitespace
Line 19:1: W293 blank line contains whitespace
Line 26:1: W293 blank line contains whitespace
Line 28:1: W293 blank line contains whitespace
Line 31:59: W292 no newline at end of file

In the file scripts/retrieve_supply_regions.py:

Line 6:1: W293 blank line contains whitespace
Line 7:68: E502 the backslash is redundant between brackets
Line 15:1: W293 blank line contains whitespace
Line 16:1: W293 blank line contains whitespace
Line 16:1: W391 blank line at end of file

Comment last updated at 2024-12-12 16:05:13 UTC

samgdotson added 30 commits July 17, 2024 15:48

updates git ignore and zoning map

0166a09

adds snakefile and the steps required for pulling residential data

be79c90

adds rule to build the dag file

5d48685

starts adding utility access feature

bc17302

adds steps to get relevant utility rates (no processing)

d3383d3

updates the residential load retrieval

52cce01

adds rule to download project sunroof data

9ec5bfb

propagates update to affected rules

0c51a31

commits local updates

9a962ff

pep8 fixes for census data retrieval

b772eb6

pep8 fixes

30b63f8

merge conf

63a3aea

adds info about rules to README

3420aa6

downloads weather data along with load data

a468aef

downloads total building data

a06a687

adds rule to retrieve lead data

92fb838

adds rule to calculate the weighted average energy expenses by buildi…

966fe2c

…ng type

adds model options to config

d22b6d2

adds hplib to environment file

c469860

adds rule to download several files from wykck gis database

08ce780

generalizes the community 'name'

7e1d1e2

propagates name change

88845c6

adds retail prices to config

49d43f4

adds rescaling rule to snakefile

c5fc2e2

adds rule to rescale load from resstock based on LEAD data

e1e730d

adds rule to retrieve nrel costs

73e8161

adds costs to targets

34a134a

updates readme and env template

7aba5cb

merge conf

404a022

updates readme

99674af

adds CI workflow

340812e

samgdotson added the enhancement New feature or request label Sep 20, 2024

samgdotson added this to the First model runs completed milestone Sep 20, 2024

samgdotson self-assigned this Sep 20, 2024

samgdotson added 10 commits September 20, 2024 11:05

adds env cache to ci

1abc59e

fixes name of environment file

6a4b537

sets targz to false

523a408

fixes api functions call

7e565e1

fixes api functions call, again

a6afdd5

removes breakpoint

e7e30ee

adds step to create env file with secret to workflow

aed7248

reduces the workflow matrix to a single run

1d754c2

updates environment and wycokck data access

dcd5128

saves the project sunroof cutout

627ec39

ssattler approved these changes Sep 24, 2024

View reviewed changes

ssattler marked this pull request as ready for review September 24, 2024 14:24

adds pep8speaks config

d8e4ee0

samgdotson marked this pull request as draft September 24, 2024 19:31

samgdotson and others added 11 commits September 25, 2024 16:18

fixes some rules and adds pypsa notebook

c8a2695

updates pypsa model

a7a2125

adds a net metering only scenario

4ad1397

adds simulations to pypsa model

507b2b4

updates pypsa model

a0b31bc

adds notebooks and data

f2b5610

adds notebooks

e54f7ac

adds outage data

ee44abb

adds oe417 files

38a3a54

adds rule to retrieve renewables

8f1b5b4

adds rule to retrieve 'supply regions'

7accf35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pypsa model #19

Pypsa model #19

samgdotson commented Sep 20, 2024

pep8speaks commented Sep 20, 2024 •

edited

Loading

Pypsa model #19

Are you sure you want to change the base?

Pypsa model #19

Conversation

samgdotson commented Sep 20, 2024

pep8speaks commented Sep 20, 2024 • edited Loading

Comment last updated at 2024-12-12 16:05:13 UTC

pep8speaks commented Sep 20, 2024 •

edited

Loading