Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor: What access level to give site admins? #13

Closed
knice opened this issue Mar 23, 2022 · 1 comment
Closed

Site Editor: What access level to give site admins? #13

knice opened this issue Mar 23, 2022 · 1 comment
Labels
documentation Improvements or additions to documentation question Further information is requested

Comments

@knice
Copy link
Member

knice commented Mar 23, 2022

Will site admins have access to the site editor?

What are the implications for theme updates if site admins can make local theme file changes?

  • Local theme file adjustments might not get updated theme template changes
  • Reverting local theme file edits will result in changes
@knice knice added documentation Improvements or additions to documentation question Further information is requested labels Mar 23, 2022
@knice
Copy link
Member Author

knice commented Mar 24, 2022

We cannot give site owners access to modify the theme within the theme editor because:

  1. Local theme changes take precedence over theme file changes. If we update the theme files and release them to a site, the updates won't take effect on the site because of a local theme edit.
  2. If the site owner clears their local theme edits so an updated theme file can take effect on their site, they lose ALL customizations they made to that file.

In short, allowing site owners to make local theme modifications prevents us from updating their theme template files in future releases of the theme.

@knice knice closed this as completed Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant