Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group cards in logical sets for binary cards interactive #1265

Open
eAlasdair opened this issue May 7, 2020 · 0 comments
Open

Group cards in logical sets for binary cards interactive #1265

eAlasdair opened this issue May 7, 2020 · 0 comments

Comments

@eAlasdair
Copy link
Contributor

eAlasdair commented May 7, 2020

Bits are grouped in sets of 4 or 8, from the LSB up. i.e. 11110 (proper form 00011110)
is more commonly viewed as 1,1110 (1E) than 1111,0 (F?).

The Binary Cards interactive uses a simple container and so groups cards like the latter. In this example the face-up cards form a standard 8-bit group but instead the 8 MSBs are grouped instead:
image

Similarly, even the opposite doesn't seem right; it appears like the 256 card belongs to the group of 8 cards, with 1 left over at the bottom. If you were to ignore the actual number of dots on the card and just read each line like binary, it is 10000000 i.e 0x80 on one line, and 0 on the other
image

When the screen is smaller this problem is expressed differently, with cards grouped in sets of however many fit next to each other on the screen.
image

Instead, I propose that the number of cards shown is forced into sets of 4 or 8 (depending on screen size). If the url parameter expresses a number of cards greater than a threshold (say 6) yet not a multiple of 4 or 8, face-down cards should be prepended to make even sets of 4/8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant