From 0fb11f2637151cf1705c42d8d4f9c54c4d1bd960 Mon Sep 17 00:00:00 2001 From: ucan-lab <35098175+ucan-lab@users.noreply.github.com> Date: Wed, 8 May 2024 10:05:50 +0900 Subject: [PATCH 1/4] chore: Add Hadolint GitHub Actions Workflow --- .github/workflows/hadolint-testing.yaml | 14 ++++++++++++++ 1 file changed, 14 insertions(+) create mode 100644 .github/workflows/hadolint-testing.yaml diff --git a/.github/workflows/hadolint-testing.yaml b/.github/workflows/hadolint-testing.yaml new file mode 100644 index 00000000..9edad4cb --- /dev/null +++ b/.github/workflows/hadolint-testing.yaml @@ -0,0 +1,14 @@ +name: Hadolint Testing +on: + pull_request: + types: [synchronize, opened, reopened] +jobs: + hadolint-testing: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v4 + with: + fetch-depth: 0 + - uses: hadolint/hadolint-action@v3.1.0 + with: + recursive: true From b650bd7342be1e6993493c069e65daa05eec5712 Mon Sep 17 00:00:00 2001 From: ucan-lab <35098175+ucan-lab@users.noreply.github.com> Date: Wed, 8 May 2024 10:11:18 +0900 Subject: [PATCH 2/4] chore: DL3008 warning: Pin versions in apt get install. Instead of `apt-get install ` use `apt-get install =` --- infra/docker/php/Dockerfile | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/infra/docker/php/Dockerfile b/infra/docker/php/Dockerfile index 63e1a1d0..2be4ec0a 100644 --- a/infra/docker/php/Dockerfile +++ b/infra/docker/php/Dockerfile @@ -19,13 +19,13 @@ COPY --from=composer:2.7 /usr/bin/composer /usr/bin/composer RUN < Date: Wed, 8 May 2024 10:11:29 +0900 Subject: [PATCH 3/4] chore: DL3009 info: Delete the apt-get lists after installing something --- infra/docker/php/Dockerfile | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/infra/docker/php/Dockerfile b/infra/docker/php/Dockerfile index 2be4ec0a..499b5278 100644 --- a/infra/docker/php/Dockerfile +++ b/infra/docker/php/Dockerfile @@ -41,15 +41,12 @@ RUN < Date: Wed, 8 May 2024 10:12:15 +0900 Subject: [PATCH 4/4] fix: Rename workflow --- .github/workflows/deploy-build-testing.yaml | 4 ++-- .github/workflows/laravel-create-project.yaml | 4 ++-- .github/workflows/laravel-git-clone.yaml | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/deploy-build-testing.yaml b/.github/workflows/deploy-build-testing.yaml index 20f0652a..0e052494 100644 --- a/.github/workflows/deploy-build-testing.yaml +++ b/.github/workflows/deploy-build-testing.yaml @@ -1,10 +1,10 @@ -name: deploy-build-testing +name: Deploy Build Testing on: pull_request: schedule: - cron: '0 0 * * *' jobs: - docker-build: + deploy-build-testing: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 diff --git a/.github/workflows/laravel-create-project.yaml b/.github/workflows/laravel-create-project.yaml index c6bc9a87..b7a9f27d 100644 --- a/.github/workflows/laravel-create-project.yaml +++ b/.github/workflows/laravel-create-project.yaml @@ -1,10 +1,10 @@ -name: laravel-create-project +name: Laravel Create Project on: pull_request: schedule: - cron: '0 0 * * *' jobs: - docker-build: + laravel-create-project: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 diff --git a/.github/workflows/laravel-git-clone.yaml b/.github/workflows/laravel-git-clone.yaml index 7621978d..cd7f0bf0 100644 --- a/.github/workflows/laravel-git-clone.yaml +++ b/.github/workflows/laravel-git-clone.yaml @@ -1,10 +1,10 @@ -name: laravel-git-clone +name: Laravel Git Clone on: pull_request: schedule: - cron: '0 0 * * *' jobs: - docker-build: + laravel-git-clone: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4