Disable manual download buttons during checksum test #2622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After manually downloading a file, a checksum test is performed on the file. For large files this test can take some time (seconds), and there's currently no indication in the UI that this is taking place. This change disables the file selector and "Continue" buttons during the checksum test, changing the text in the button to "Checking..." instead. This provides immediate feedback for the user and avoids the confusion of allowing them to still use the buttons while the check is taking place.
Codecov Report
@@ Coverage Diff @@
## master #2622 +/- ##
==========================================
+ Coverage 76.20% 76.25% +0.04%
==========================================
Files 29 29
Lines 954 956 +2
==========================================
+ Hits 727 729 +2
Misses 227 227
Continue to review full report at Codecov.
|
maciek134
approved these changes
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After manually downloading a file, a checksum test is performed on the
file. For large files this test can take some time (seconds), and
there's currently no indication in the UI that this is taking place.
This change disables the file selector and "Continue" buttons during the
checksum test, changing the text in the button to "Checking..." instead.
This provides immediate feedback for the user and avoids the confusion
of allowing them to still use the buttons while the check is taking
place.