Use sveltestrap #2559
Merged
Use sveltestrap #2559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2559 +/- ##
=======================================
Coverage 76.56% 76.56%
=======================================
Files 29 29
Lines 960 960
=======================================
Hits 735 735
Misses 225 225 Continue to review full report at Codecov.
|
NeoTheThird
approved these changes
Jun 3, 2022
yep, that'd make quickly resolving conflicts easier, too. but no pressure :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds sveltestrap. This will allow easier ui composition and lower styling/logic boilerplate.
I brought back the accordion in the dev mode modal and simplified the base component of all modals. In a next step maybe modals could have their own state handling.
@NeoTheThird let me know what you think about it.
PS: I probably could have opened this PR from a branch inside this repo. :P