Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow specifying compatible_installer per os #2518

Merged
merged 1 commit into from
Mar 20, 2022
Merged

Conversation

NeoTheThird
Copy link
Member

resolves #2509

@codecov
Copy link

codecov bot commented Mar 20, 2022

Codecov Report

Merging #2518 (64322ed) into master (94e7dd3) will increase coverage by 0.76%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #2518      +/-   ##
==========================================
+ Coverage   74.28%   75.05%   +0.76%     
==========================================
  Files          29       29              
  Lines         941      950       +9     
==========================================
+ Hits          699      713      +14     
+ Misses        242      237       -5     
Impacted Files Coverage Δ
src/lib/mainEvent.js 35.10% <25.00%> (-0.45%) ⬇️
src/core/core.js 72.46% <100.00%> (+7.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94e7dd3...64322ed. Read the comment docs.

@NeoTheThird
Copy link
Member Author

Don't worry about codecov there, mainevent was not tested yet previously and starting that now is out of scope for this

@NeoTheThird NeoTheThird merged commit acee60c into master Mar 20, 2022
@NeoTheThird NeoTheThird deleted the installer-version branch March 20, 2022 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow specifying minimum required installer version
2 participants