Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further modularization #1567

Merged
merged 10 commits into from
Nov 22, 2020
Merged

Further modularization #1567

merged 10 commits into from
Nov 22, 2020

Conversation

NeoTheThird
Copy link
Member

Last one for this round :)

@NeoTheThird NeoTheThird self-assigned this Nov 21, 2020
@codecov-io
Copy link

codecov-io commented Nov 21, 2020

Codecov Report

Merging #1567 (11a3ecb) into master (4fc475e) will increase coverage by 10.26%.
The diff coverage is 45.93%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1567       +/-   ##
===========================================
+ Coverage   29.28%   39.54%   +10.26%     
===========================================
  Files          14       17        +3     
  Lines         642      665       +23     
===========================================
+ Hits          188      263       +75     
+ Misses        454      402       -52     
Impacted Files Coverage Δ
src/devices.js 5.28% <1.26%> (+0.41%) ⬆️
src/lib/mainEvent.js 27.72% <27.72%> (ø)
src/lib/errors.js 47.36% <44.44%> (+1.91%) ⬆️
src/lib/system-image.js 19.44% <50.00%> (+2.30%) ⬆️
src/main.js 36.92% <50.00%> (+11.92%) ⬆️
src/lib/cli.js 71.42% <60.00%> (-28.58%) ⬇️
src/lib/reporter.js 94.73% <94.73%> (ø)
src/lib/cache.js 66.66% <100.00%> (+12.12%) ⬆️
src/lib/deviceTools.js 57.89% <100.00%> (+2.33%) ⬆️
src/lib/log.js 100.00% <100.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fc475e...11a3ecb. Read the comment docs.

@NeoTheThird
Copy link
Member Author

Still looking a bit messy, but we're getting there!
arch

Flohack74
Flohack74 previously approved these changes Nov 22, 2020
@NeoTheThird NeoTheThird merged commit 7f86529 into master Nov 22, 2020
@NeoTheThird NeoTheThird deleted the further-modularization branch November 22, 2020 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants