Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error handling in some plugin APIs broken for non-network errors #1840

Closed
vdagguma opened this issue Mar 10, 2021 · 2 comments
Closed

error handling in some plugin APIs broken for non-network errors #1840

vdagguma opened this issue Mar 10, 2021 · 2 comments
Assignees
Labels
bug a bug in the software itself

Comments

@vdagguma
Copy link

UBports Installer 0.8.7-beta (snap)
Environment: Ubuntu Core 20 linux 5.8.0-44-generic x64 NodeJS v12.18.3
Device: jasmine_sprout
Target OS: Ubuntu Touch
Settings: undefined
OPEN-CUTS run: https://ubports.open-cuts.org/run/60484e2a52bd840007f91e8a
Log: N/A

After installing stock android 9 and rebooted into recovery mode, it is trying "Adb is scanning for devices" and finally got this error

@vdagguma
Copy link
Author

This is for mi A2 device

@NeoTheThird
Copy link
Member

error: Error: systemimage:install: TypeError: Cannot read property 'status' of undefined
stack trace: TypeError: Cannot read property 'status' of undefined
    at /snap/ubports-installer/348/app/resources/app.asar/src/core/plugins/systemimage/api.js:81:26
    at processTicksAndRejections (internal/process/task_queues.js:97:5)

Looks like we messed up the error handling a little there. That's a bug.

@NeoTheThird NeoTheThird added the bug a bug in the software itself label Mar 10, 2021
@NeoTheThird NeoTheThird changed the title After installing stock android 9 and rebooted into recovery mode, it is trying "Adb is scanning for devices" and finally got this error error handling in some plugin APIs broken for non-network errors Mar 10, 2021
@NeoTheThird NeoTheThird self-assigned this Mar 18, 2022
calebccff pushed a commit to calebccff/ubports-installer that referenced this issue Mar 19, 2022
llewelld pushed a commit to llewelld/ubports-installer that referenced this issue Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug a bug in the software itself
Projects
None yet
Development

No branches or pull requests

2 participants