Over time, it has been found that insufficient testing by reviewers sometimes leads to file manager app trunk not buildable due to manifest errors, or translation pot file not updated. As such, please follow the checklist below before top-approving a PR.
-
Does the PR add/remove user visible strings? If Yes, has the pot file been updated?
-
Does the PR change the UI? If Yes, has it been approved by design?
-
Did you perform an exploratory manual test run of your code change and any related functionality?
-
If the PR fixes a bug or implements a feature, are there accompanying unit and autopilot tests?
-
Is the file manager app buildable and runnable using clickable?
-
Was the copyright years updated if necessary?
The above checklist is more of a guideline to help file manager app stay buildable, stable and up to date.