Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readd devcontainer support #2046

Open
GarciaLnk opened this issue Dec 14, 2024 · 4 comments · May be fixed by #2131
Open

Readd devcontainer support #2046

GarciaLnk opened this issue Dec 14, 2024 · 4 comments · May be fixed by #2131
Labels
dx Developer Experience Image specific enhancement New feature or request

Comments

@GarciaLnk
Copy link
Contributor

The previous devcontainer went missing since the build process was reorganized, I suggest readding a devcontainer that eases off the development process when it's done on a non-bluefin host.

Since podman is not very well-supported on devcontainers it may be needed to modify the Justfile workflow to allow the usage of docker in the build process.

@dosubot dosubot bot added dx Developer Experience Image specific enhancement New feature or request labels Dec 14, 2024
@m2Giles
Copy link
Member

m2Giles commented Dec 15, 2024

That's why it was removed. The justfile was designed to use tools that will be on every ublue image. It uses bash, coreutils, curl, skopeo, jq, and podman (python for changelogs only). Devcontainers don't work well with podman. Additionally for rechunk and the ISO build it requires a rootful container with quite a bit of privileges. While it would work if using a privileged docker container, I'm unsure if shipping that as a recommended solution makes the most sense.

It also would require quite a bit of rework of the justfile to handle using docker instead and I would be concerned about code rot given what happened with the previous version of the justfile.

That said, I'm not 100% against it, but it will require a bit of work.

@GarciaLnk
Copy link
Contributor Author

Given that the devcontainer would only be used for local development, we could omit the rechunk step for that use case, being able to build an image and an .iso inside a devcontainer would be enough imo.

@m2Giles
Copy link
Member

m2Giles commented Dec 19, 2024

iso and rechunk both need privileges.

@m2Giles
Copy link
Member

m2Giles commented Jan 7, 2025

It is now possible to use the just actions with docker now using changes from #2114. If podman doesn't exist it will attempt to use docker or docker can be explicitly specified with an environment variable.

This means that a docker outside of docker devcontainer could be used. For docker inside of docker, you would need to use a privileged container (which I believe is the default for docker in Docker).

@GarciaLnk GarciaLnk linked a pull request Jan 9, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx Developer Experience Image specific enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants