-
-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: purge all the default container configuration #1901
chore: purge all the default container configuration #1901
Conversation
So I don't mean to hijack this PR. But, looks like the profile setup for ptyxis changed, and now that we have more users people are getting confused. It might be worth to just rip all of these out and just ship distrobox/boxbuddy blank out of the box:
|
124d5c6
to
6711006
Compare
Just converted this into a draft cuz this PR seems kinda big and probably needs a lot more confirmation from everyone |
I agressively just removed everything related to those default containers, please tell me if you guys dont want something removed!! Im just wondering about the podmansh.container file in /usr/share/ublue-os/quadlet and /usr/bin/bluefinbox-enter. Should those be removed too? |
After testing it a bit, this seems fine? Nothing seems to have broken, nothing seems to have changed majorly, my vm seems completely ok and happy |
Although that ptyxis-create-profile command doesnt seem to be working too well if Ptyxis's dconf keys get reset. It just errors out trying to set transparency since it cant read the default profile uuid off of dconf |
I think we can land this after the conflicts get resolved, and then I'll remove this section from the docs, thanks! |
Oh! I didnt even like see the conflicts here LOL i was just editing stuff directly on the my local copy. Sorry! Ill resolve them rn |
50fa1bb
to
94ad2cc
Compare
593134d
to
766d893
Compare
Hopefully this should be good now |
system_files/silverblue/etc/dconf/db/distro.d/02-bluefin-keybindings
Outdated
Show resolved
Hide resolved
d9dc485
to
fd8e841
Compare
Are the containers themselves being depreciated or just the bluefin default integration? If it's just the default integration could this be left in the dx version or convert setup to ujust scripts? I was a bit caught of guard when #1908 ripped out the bluefin-cli after an updated and it's a but unclear if the container's being depreciated or just the bluefin integration. |
fd8e841
to
c8be46e
Compare
What's specifically being deprecated is the ephemeral containers that we shipped on ctrl+alt+f and ctrl+alt+u (fedora/ubuntu) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only other thought I have, is that the user's targets for the quadlets are going to just still be there. I'm hesitant to auto clean them up in case someone goes the same route for enabling them.
Additionally, we should probably update the distrobox.ini files in toolboxes in case people want to consume with distrobox's ability to use assemble with a url now.
Specifically, there were targets for the following:
ubuntu-toolbox.target
fedora-toolbox.target
bluefin-cli.target
wolfi-toolbox.target
bluefin-cli-dx.target
wolfi-dx-toolbox.target
@tulilirockz I noticed that after your branch updates it seems to be missing the custom2 vs custom3 in the keybindings again. Just to let you know ❤️ |
oh great. :p |
4368568
to
80202e6
Compare
You applied the commit via my review, that is probably why the commit is missing now. Probably need to commit it again by yourself |
c3f3acd
to
7528f24
Compare
This is looking good. My only hesitations are cleaning up the old targets and using the name Host for the profile. Instead I think all of the ptyxis profile manipulation can be ripped out. You should be able to use uuid for the shortcut and it will then just open whatever that profile is configured with. |
We also shoukd change the build script orders too since the 06 script got removed - I dont think this should be done in this PR since itll bring merge conflicts unnecessarily AFAIK |
405ff6c
to
e3355d4
Compare
Do you think that should be done here? It does bring out the scope a bit - still, great idea! Cleaning up the old targets dont seem like such a huge problem, as this is mostly targeted at new systems that dont have those targets yet, if someone actually notices that those are running, they can remove/disable them on their own I think. |
db26104
to
64d9160
Compare
Co-authored-by: befanyt <[email protected]>
Co-authored-by: m2 <[email protected]>
Head branch was pushed to by a user without write access
64d9160
to
1d3c190
Compare
sorry thought rebasing wouldnt disable auto-merge |
Co-authored-by: befanyt <[email protected]> Co-authored-by: m2 <[email protected]>
I believe these are all the references to the Bluefin-CLI container. Probably should not be merged right now? Maybe disabiling the service files then deleting the references seems like the best approach, as Jorge said.
The updated title is just a joke! We talked about this on discord and it seems like it would be best to just get rid of the default containers and stuff
From Jorge:
Affects stuff like #1834 and #1881