From f63191d363bfd817623f806836d574a43dc06a32 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jean-S=C3=A9bastien=20Pelletier?=
 <jean-sebastien.pelletier@ubisoft.com>
Date: Mon, 28 Oct 2024 08:37:04 -0400
Subject: [PATCH] tech debt: Removed dead code

Nothing is ever writing to UnResolvedProtectedDependencies and the property is internal so it is safe to remove it.
---
 Sharpmake/Project.Configuration.cs | 4 +---
 Sharpmake/Project.cs               | 1 -
 2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/Sharpmake/Project.Configuration.cs b/Sharpmake/Project.Configuration.cs
index 03f695eae..6d2af2f36 100644
--- a/Sharpmake/Project.Configuration.cs
+++ b/Sharpmake/Project.Configuration.cs
@@ -2586,8 +2586,6 @@ public bool DefaultAddFastBuildProjectToSolution()
 
             // These dependencies will not be propagated to other projects that depend on us
             internal IDictionary<Type, ITarget> UnResolvedPrivateDependencies { get; } = new Dictionary<Type, ITarget>();
-            // These dependencies will be propagated to other dependent projects, but not across dll dependencies.
-            internal IDictionary<Type, ITarget> UnResolvedProtectedDependencies { get; } = new Dictionary<Type, ITarget>();
             // These dependencies are always propagated to other dependent projects.
             internal Dictionary<Type, ITarget> UnResolvedPublicDependencies { get; } = new Dictionary<Type, ITarget>();
 
@@ -3056,7 +3054,7 @@ public bool HaveDependency<TPROJECT>()
 
             public bool HaveDependency(Type projectType)
             {
-                return UnResolvedPrivateDependencies.ContainsKey(projectType) || UnResolvedProtectedDependencies.ContainsKey(projectType) || UnResolvedPublicDependencies.ContainsKey(projectType);
+                return UnResolvedPrivateDependencies.ContainsKey(projectType) || UnResolvedPublicDependencies.ContainsKey(projectType);
             }
 
             /// <summary>
diff --git a/Sharpmake/Project.cs b/Sharpmake/Project.cs
index 60a8a813f..5e6f4c036 100644
--- a/Sharpmake/Project.cs
+++ b/Sharpmake/Project.cs
@@ -1614,7 +1614,6 @@ internal HashSet<Type> GetUnresolvedDependenciesTypes()
             foreach (Project.Configuration conf in Configurations)
             {
                 dependencies.UnionWith(conf.UnResolvedPublicDependencies.Keys);
-                dependencies.UnionWith(conf.UnResolvedProtectedDependencies.Keys);
                 dependencies.UnionWith(conf.UnResolvedPrivateDependencies.Keys);
             }
             return dependencies;