fix: reimpliment highlight functionality on rate limit #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gentlementlegen This cypress error seems to reoccur intermittently. Can you look into this? Doesn't seem like a good idea to merge commits that aren't passing CI |
0x4007
approved these changes
Aug 18, 2024
|
@0x4007 it looks like it was deleted by you when you were re-implementing error toast |
|
@0x4007 This test has been failing for quite some time but it seems that PRs went in regardless. I think it's one line of code to remove in the test, because the bottom bar does not scroll anymore (got changed when FAQ button was added I believe). I will commit in this PR. Should be good to go now. Also tested the last build, the login button shines on desktop and mobile on rate limitation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #78
