Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variables into wrangler deployment script #151

Open
gentlementlegen opened this issue Nov 2, 2024 · 0 comments · May be fixed by #163
Open

Add variables into wrangler deployment script #151

gentlementlegen opened this issue Nov 2, 2024 · 0 comments · May be fixed by #163

Comments

@gentlementlegen
Copy link
Member

          All of the KV setup is automated via the Action deployment script, these variables should be described there. [This](https://github.com/ubiquity/work.ubq.fi/pull/123/files#diff-b1b9719b6eae4103d520f1e902420f5073b5e18a5a47aa73feed71a037557c98R9) should not have been commited as such. Example from the plugin: https://github.com/ubiquity-os/plugin-template/blob/development/.github/workflows/worker-deploy.yml#L34

By hardcoding the bindings if we change org / try to deploy on our own, it will break.

Originally posted by @gentlementlegen in #123 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant