-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fix live reload #359
base: development
Are you sure you want to change the base?
Conversation
Unused devDependencies (1)
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Unit tests are failing here. They need your attention.
-
npm-run-all
should be in dev dependencies. -
Would be nice if
watch
can also do a littleTimestamp: Build started...
,Timestamp: Build finished...
message to give feedback on console too. Currently it just stays silent on rebuild.
@zugdev, this task has been idle for a while. Please provide an update. |
Tests are failing in |
Unit tests are not failing in |
@EresDev pardon, you are correct. Do you have any idea why it fails? I can't run these tests locally, and the changes seem very harmless. They might be a problem if under the hood the tests rely on |
Tests are passing for me either I keep or remove nodemon. The problem can be the |
If the problem is in yarn.lock then some package should be added to package.json. I have no means of using "development" yarn.lock, I will commit it here but I am not able to run tests locally because the yarn.lock does not reflect my installed packages. |
Unit tests are passing. Now run the |
That won't work.
The esbuild API has a build info option but IMO it's not useful and adds text overhead. I will enable it, tho. |
I tried that. It was working for me. |
Resolves #358