Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix live reload #359

Open
wants to merge 7 commits into
base: development
Choose a base branch
from
Open

Conversation

zugdev
Copy link
Contributor

@zugdev zugdev commented Nov 13, 2024

Resolves #358

@zugdev zugdev requested a review from Keyrxng as a code owner November 13, 2024 02:26
@zugdev zugdev requested review from 0x4007 and removed request for Keyrxng November 13, 2024 02:26
Copy link
Contributor

Unused devDependencies (1)

Filename devDependencies
package.json nodemon

@ubiquity-os-deployer
Copy link

ubiquity-os-deployer bot commented Nov 13, 2024

Copy link
Contributor

github-actions bot commented Nov 13, 2024

Preview Deployment
7dc6d634506640ee2d0d935ab3781db7e8cfdf76

Copy link
Contributor

@EresDev EresDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Unit tests are failing here. They need your attention.

  • npm-run-all should be in dev dependencies.

  • Would be nice if watch can also do a little Timestamp: Build started..., Timestamp: Build finished... message to give feedback on console too. Currently it just stays silent on rebuild.

Copy link
Contributor

ubiquity-os bot commented Nov 18, 2024

@zugdev, this task has been idle for a while. Please provide an update.

build/esbuild-watch.ts Outdated Show resolved Hide resolved
@zugdev
Copy link
Contributor Author

zugdev commented Nov 22, 2024

  • Unit tests are failing here. They need your attention.

Tests are failing in development branch. I've looked into it and it doesn't seem to be induced by the presented changes. @EresDev please let me know if you think it is. Else, we should create another issue to look at it.

@EresDev
Copy link
Contributor

EresDev commented Nov 24, 2024

Tests are failing in development branch.

Unit tests are not failing in development branch. They are passing there.

@zugdev
Copy link
Contributor Author

zugdev commented Nov 27, 2024

@EresDev pardon, you are correct. Do you have any idea why it fails? I can't run these tests locally, and the changes seem very harmless. They might be a problem if under the hood the tests rely on yarn start or similar.

@EresDev
Copy link
Contributor

EresDev commented Nov 27, 2024

Do you have any idea why it fails?

Tests are passing for me either I keep or remove nodemon. The problem can be the yarn.lock. You should try with yarn.lock file from the development branch.

@zugdev
Copy link
Contributor Author

zugdev commented Nov 27, 2024

If the problem is in yarn.lock then some package should be added to package.json. I have no means of using "development" yarn.lock, I will commit it here but I am not able to run tests locally because the yarn.lock does not reflect my installed packages.

@EresDev
Copy link
Contributor

EresDev commented Nov 28, 2024

Unit tests are passing. Now run the yarn install and commit the updated yarn.lock. You also have other points to look into.

@zugdev
Copy link
Contributor Author

zugdev commented Nov 28, 2024

Unit tests are passing. Now run the yarn install and commit the updated yarn.lock.

That won't work.

You also have other points to look into.

The esbuild API has a build info option but IMO it's not useful and adds text overhead. I will enable it, tho.

@EresDev
Copy link
Contributor

EresDev commented Nov 28, 2024

That won't work.

I tried that. It was working for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix live reload
3 participants