-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: call db to retrieve permits instead of parsing github comments #164
Changes from 4 commits
35d0b99
7528f3e
2b21d66
655ead5
72b23f2
3b7c3d2
2f11234
0878552
a1c6e4b
0ba50af
5a504fd
ba87b12
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -177,10 +177,10 @@ export const isValidUrl = (urlString: string) => { | |
} | ||
}; | ||
|
||
export const getCurrency = (comment: string) => { | ||
if (comment.includes("WXDAI")) { | ||
export const getCurrency = (id: number) => { | ||
if (id === 100) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should be handled dynamically I think. We should be able to support any network and any token. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No problem on using it as is, but it seems to be converted into a string value corresponding to its currency, so I have no clue if this value impacts any other project, so please let me know and I can use the number instead. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
I don't understand what you're saying but network 100 is Gnosis Chain which we use for most of our payouts now. However we want partners to be able to use any network (just as long as there is a permit2 smart contract deployment on it, it should be fine!) |
||
return Chain.Gnosis; | ||
} else if (comment.includes("DAI")) { | ||
} else if (id === 1) { | ||
return Chain.Ethereum; | ||
} | ||
return null; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we need to add this to our repo secrets?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the necessary values and tried rerunning the CI but it failed again. Perhaps you can try pushing to force it to run again? I have a feeling you may not be loading in the secrets correctly though. Did you prove this works on your local?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My local works fine, I'll have a look at the logs. Also it uses the Supabase you shared to me