Update README.md #65
Update README.md #65
Conversation
Added description on how to run example projects without Carthage
|
@jbrophy17 check this one please🙂 |
|
Thanks for the PR, just need to verify the steps are accurate and then I'll merge this in :) |
|
|
||
| For Objective-C projects, set the **Embedded Content Contains Swift Code** flag in your project to **Yes** (found under **Build Options** in the **Build Settings** tab). | ||
|
|
||
| Open .xcworkspace and navigate to **General** tab, scroll to **Embedded Binaries** select ObjectMapper.framework and click the `-` button, do the same for UberRides.framework. Now go to **Build Settings** tab and scroll to **Search Paths**, click on *Framework Search Paths** and remove the line $(PROJECT_DIR)/Carthage/Build/iOS. |
There was a problem hiding this comment.
Framework Search Paths* is missing an asterisk, should be Framework Search Paths
|
@lashkhi sorry for the delay! Left a few comments, once we clean these up I can go ahead and merge it |
Text clean up: removed copy & paste issues, added more attention to removing Carthage
|
@jbrophy17 Hi, no problem for delay! Thanks for reviewing it— I've made changes you commented on. |
|
|
||
| For Objective-C projects, set the **Embedded Content Contains Swift Code** flag in your project to **Yes** (found under **Build Options** in the **Build Settings** tab). | ||
|
|
||
| Open .xcworkspace and navigate to **General** tab, scroll to **Embedded Binaries** select ObjectMapper.framework and click the `-` button, do the same for UberRides.framework. Now go to **Build Settings** tab and scroll to **Search Paths**, click on **Framework Search Paths** and remove the line $(PROJECT_DIR)/Carthage/Build/iOS. |
There was a problem hiding this comment.
I also think it makes sense to move this section right after steps to remove dependencies. That way, removing all the carthage stuff comes first, and then the Cocoapods steps
|
just a few more comments, otherwise it is looking good |
Put the section for removing Carthage together, some text changes for better understanding
|
@jbrophy17 Yeah, that makes sense. Updated 🙂 |
| @@ -930,9 +930,11 @@ carthage update --platform iOS | |||
| This will build the required dependencies. Once you do that, open `Swift SDK.xcodeproj` or `Obj-C SDK.xcodeproj` in Xcode and run it. | |||
|
|
|||
| ### CocoaPods | |||
| First, you will have to remove Carthage dependencies. Navigate to `examples/Swift SDK` or `examples/Obj-C SDK` and remove `Cartfile` and `Cartfile.resolved`. If you see a `Carthage` folder, remove that as well. | |||
| First, you will have to remove Carthage dependencies. Navigate to `examples/Swift SDK` or `examples/Obj-C SDK` and remove `Cartfile` and `Cartfile.resolved`. If you see a `Carthage` folder, remove that as well. Open .xcworkspace and navigate to **General** tab, scroll to **Embedded Binaries** select `ObjectMapper.framework` and click the `-` button, do the same for `UberRides.framework`. Now go to **Build Settings** tab and scroll to **Search Paths**, click on **Framework Search Paths** and remove the line $(PROJECT_DIR)/Carthage/Build/iOS. | |||
| Now got to **Build Phases** find the **Copy Carthage Frameworks** and remove it. | |||
There was a problem hiding this comment.
Minor typo here, "got to" instead of "go to"
|
Hey @lashkhi sorry for the delay here, just one minor typo and then I will merge this in |
|
@jbrophy17 Oh, sorry for this mistake— fixed it already |
|
Awesome, looks good |
Added description on how to run example projects without Carthage