Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erichg/auth strategy #242

Merged
merged 6 commits into from
Sep 7, 2018
Merged

Erichg/auth strategy #242

merged 6 commits into from
Sep 7, 2018

Conversation

ebgraham
Copy link
Contributor

@ebgraham ebgraham commented Sep 4, 2018

The new parameter productFlowPriority on LoginManager allows you to authenticate with UberEats or Uber rides, with the ability to fallback between them (e.g. if Eats isn't installed then try the rides app). By default, uses Uber rides app which makes this a non-breaking change.

Right now for web auth UberEats will still use the rides flow, but in a future update it will use its own web auth provider.

Due to Obj-c compatibility the API is a bit messier than I would've preferred.

@ebgraham ebgraham requested a review from edjiang September 4, 2018 20:49
Copy link
Contributor

@edjiang edjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@ebgraham ebgraham merged commit 1a32600 into develop Sep 7, 2018
@ebgraham ebgraham deleted the erichg/AuthStrategy branch September 7, 2018 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants