Crash bug when processing SSO return under Xcode 9.3 #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"<App Name>" wants to open "Uber" Cancel / Open would cause SSO to fail because the system dialog triggers the UIApplicationDidBecomeActive notification. The fix is to make sure that the notification is preceded by a UIApplicationWillEnterForeground notification, which happens only when the there's been a context switch to the Uber app. Fixed a related bug where, if the user were to select Cancel in the system dialog box (above), the library would attempt to use fallback to a web view, when the correct handling would be to stop attempting to log in and return an error to the caller.
…s to appear as if the user did not follow them when they actually did.
…arious "annotation" parameters are declared as "Any", which means that they cannot be nil. With the new version of the compiler, a nil value causes a runtime crash, and the source of this parameter, the application's incoming value for options[UIApplicationOpenURLOptionsAnnotationKey] is typically nil. Passing a nil value as annotation directly actually results in the following compilation error: "Null passed to a callee that requires a non-null argument", as further evidence of the issue. The fix is to make annotation an optional parameter ("Any?" instead of "Any") in the various places it is used.
…tead of "Any?" (i.e. optional, since it can be nil). Fixed a compilation issue in UberCoreTests.
|
Sorry about yesterday's pull request... I hadn't checked the test code to make sure it compiled. Today's fixes that and catches a few more places where "annotation" was required to be non-nil. |
|
No problem, thanks @lhasiuk! |
|
Any blockers on merging this? |
|
No blockers -- just my time. Sorry! 😅 I'll bump the version later today. |
edjiang
pushed a commit
that referenced
this pull request
Apr 27, 2018
* Fixed an issue that appears when compiled with Xcode 9.3, where the various "annotation" parameters are declared as "Any", which means that they cannot be nil. With the new version of the compiler, a nil value causes a runtime crash, and the source of this parameter, the application's incoming value for options[UIApplicationOpenURLOptionsAnnotationKey] is typically nil. Passing a nil value as annotation directly actually results in the following compilation error: "Null passed to a callee that requires a non-null argument", as further evidence of the issue. The fix is to make annotation an optional parameter ("Any?" instead of "Any") in the various places it is used.
* Fixed a few more places where "annotation" was declared as "Any", instead of "Any?" (i.e. optional, since it can be nil).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue that appears when compiled with Xcode 9.3, where the various "annotation" parameters are declared as "Any", which means that they cannot be nil. With the new version of the compiler, a nil value causes a runtime crash, and the source of this parameter, the application's incoming value for options[UIApplicationOpenURLOptionsAnnotationKey] is typically nil. Passing a nil value as annotation directly actually results in the following compilation error: "Null passed to a callee that requires a non-null argument", as further evidence of the issue. The fix is to make annotation an optional parameter ("Any?" instead of "Any") in the various places it is used.