Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the benefits of Swift 4 is that it defines a new set of object serialization/deserialization APIs. Since the SDK currently depends on
ObjectMapper
, a 3rd party library, for its JSON handling, I thought it'd be a good idea to move offObjectMapper
to theCodable
APIs.Also, the models were all previously optionals. This makes the SDK harder to use, so I went through the models and added the correct nullability according to documentation and test responses we have.
Note: For primitive types, we do not make them optional. This is because Objective-C will not import optional primitives, and these properties will be inaccessible.
As an alternative, we could use the correct nullability for primitives and attempt to use this workaround to expose objective-c only properties. See Stack Overflow post
See: