Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate to Swift 4 using the auto migrator + manual audits of the migration.
The primary impact of Swift 4 on our codebase is that Swift 4 no longer automatically generates Objective-C entry points for subclasses of Objective C objects. Since our codebase is meant to be consumed from Objective-C clients as well as Swift only clients, we need to add
@objc
annotations to tell the compiler to still generate these entry points.See:
Also, the
private
access control modifier gained a bit of scope, makingfileprivate
unnecessary for the most part.See: