Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Swift 4 #178

Merged
merged 1 commit into from
Sep 13, 2017
Merged

Migrate to Swift 4 #178

merged 1 commit into from
Sep 13, 2017

Conversation

edjiang
Copy link
Contributor

@edjiang edjiang commented Aug 31, 2017

Migrate to Swift 4 using the auto migrator + manual audits of the migration.

The primary impact of Swift 4 on our codebase is that Swift 4 no longer automatically generates Objective-C entry points for subclasses of Objective C objects. Since our codebase is meant to be consumed from Objective-C clients as well as Swift only clients, we need to add @objc annotations to tell the compiler to still generate these entry points.

See:

Also, the private access control modifier gained a bit of scope, making fileprivate unnecessary for the most part.

See:

@edjiang edjiang requested a review from bobz August 31, 2017 22:06
@edjiang edjiang mentioned this pull request Sep 1, 2017
7 tasks
@edjiang edjiang changed the base branch from swifty-apis to develop September 13, 2017 01:09
@edjiang edjiang force-pushed the swift-4-migration-pt-1 branch from b9931d0 to 1027692 Compare September 13, 2017 19:06
@edjiang edjiang merged commit c91d385 into develop Sep 13, 2017
@edjiang edjiang deleted the swift-4-migration-pt-1 branch September 15, 2017 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants