Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create pt-br localizable.string #138

Merged
merged 1 commit into from
Jul 11, 2017
Merged

Create pt-br localizable.string #138

merged 1 commit into from
Jul 11, 2017

Conversation

gloffreda
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Nov 28, 2016

CLA assistant check
All committers have signed the CLA.

@gloffreda gloffreda mentioned this pull request Nov 29, 2016
@jbrophy17
Copy link
Contributor

Thanks for the PR! Once I verify these translations, I'll be happy to merge this in

Copy link
Contributor

@jbrophy17 jbrophy17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2 minor changes, otherwise everything looks good!

"User cancelled the login process." = "Usuário cancelou processo de login.";
"Try Again" = "Tente novamente";
"Cancel" = "Cancelar";
"The operation you are attempting is not supported on the current device." = "A operação não pode ser executado neste tipo de equipamento.";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we change "equipamento" to "aparelho"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure. it fits better !

"Cancel" = "Cancelar";
"The operation you are attempting is not supported on the current device." = "A operação não pode ser executado neste tipo de equipamento.";
"%d min away" = "%d min longe";
"%d mins away" = "%d mins longe";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On both of these, could we change to "a %d mins" instead of "%d mins longe" ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes you can. We had bad time trying to fit a better world here. The problem is the length.
But I think just "mins" is comprehensible.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you still planning to add pt-br ?

@Sml995
Copy link

Sml995 commented Feb 10, 2017

How can I change the localization?

@gloffreda
Copy link
Contributor Author

Is there anything I can do to have this working ?

@edjiang
Copy link
Contributor

edjiang commented Jul 6, 2017

@gloffreda I just took over this project; will see if there's anything else we need to do for localization. ^^ will see if there are any other next steps

@edjiang edjiang changed the base branch from master to swift-3-dev July 11, 2017 22:35
@edjiang edjiang merged commit 86629c6 into uber:swift-3-dev Jul 11, 2017
@edjiang
Copy link
Contributor

edjiang commented Jul 11, 2017

@gloffreda merged into the swift-3-dev branch. See #167 for how to install it.

Thanks so much for contributing!

@gloffreda
Copy link
Contributor Author

May I suggest some improvements ? Just updated my project and localization works great.
I just saw some sentences that can be improved.

@edjiang
Copy link
Contributor

edjiang commented Jul 13, 2017

@gloffreda sure, no problem. Just submit another PR! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants