-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create pt-br localizable.string #138
Create pt-br localizable.string #138
Conversation
Thanks for the PR! Once I verify these translations, I'll be happy to merge this in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just 2 minor changes, otherwise everything looks good!
"User cancelled the login process." = "Usuário cancelou processo de login."; | ||
"Try Again" = "Tente novamente"; | ||
"Cancel" = "Cancelar"; | ||
"The operation you are attempting is not supported on the current device." = "A operação não pode ser executado neste tipo de equipamento."; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we change "equipamento" to "aparelho"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure. it fits better !
"Cancel" = "Cancelar"; | ||
"The operation you are attempting is not supported on the current device." = "A operação não pode ser executado neste tipo de equipamento."; | ||
"%d min away" = "%d min longe"; | ||
"%d mins away" = "%d mins longe"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On both of these, could we change to "a %d mins" instead of "%d mins longe" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes you can. We had bad time trying to fit a better world here. The problem is the length.
But I think just "mins" is comprehensible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you still planning to add pt-br ?
How can I change the localization? |
Is there anything I can do to have this working ? |
@gloffreda I just took over this project; will see if there's anything else we need to do for localization. ^^ will see if there are any other next steps |
@gloffreda merged into the Thanks so much for contributing! |
May I suggest some improvements ? Just updated my project and localization works great. |
@gloffreda sure, no problem. Just submit another PR! :) |
No description provided.