Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept CLLocation parameter instead of coordinates as double? #13

Closed
sachinkesiraju opened this issue Feb 23, 2016 · 2 comments
Closed

Comments

@sachinkesiraju
Copy link

Passing lat/long as double values for the coordinates doesn't seem as clean as simply passing a CLLocation object (easier to directly use with Core Location's user location). [As used in UberKit: github.com/sachinkesiraju/UberKit]

@faarwa
Copy link
Contributor

faarwa commented Feb 23, 2016

You're right that a CLLocation object makes more sense to pass around. For the beta release of the SDK, we didn't want to force use of CoreLocation just to use the RequestButton which just deep links to the Uber app. When the SDK is built out to expose all the endpoints, it'll make more sense to use the CLLocation object. In the meantime, the location.coordinate.latitude/longitude properties can be passed in if using CoreLocation. I'll leave this open. Thanks!

@jbrophy17
Copy link
Contributor

Fixed in v0.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants